Circle arc behaves like merge

[ff5722]

What steps will reproduce the problem?

1. Draw a closed way
2. Create a new, separate, circle arc (Shift+C) that terminates at both ends on the boundaries or nodes of the way without any nodes between the termini
3. The closed way will merge with the boundary of the new circle arc

What is the expected result?

Closed way will not change, circle arc is only connected at it's termini

What happens instead?

The closed way will suddenly follow the circle arc

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-10-11 23:10:16 +0200 (Sun, 11 Oct 2020)
Build-Date:2020-10-12 01:30:50
Revision:17170
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17170 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 1327 MB / 2709 MB (702 MB allocated, but free)
Java version: 1.8.0_261-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080 (scaling 1.0x1.0), \Display1 1080x1920 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1920
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
Dataset consistency test: No problems found

Plugins:
+ Create_grid_of_ways (35405)
+ FastDraw (35499)
+ apache-commons (35524)
+ apache-http (35092)
+ buildings_tools (35574)
+ ejml (35313)
+ geotools (35169)
+ gridify (1588746833)
+ importvec (35499)
+ jaxb (35092)
+ jna (35092)
+ jts (35122)
+ mapwithai-dev (1.5.5-192-g9d87fe5)
+ opendata (35513)
+ reverter (35556)
+ terracer (35560)
+ utilsplugin2 (35487)

Tagging presets:
+ E:\Nextcloud\Documents\Openstreetmap\JOSM presets\CellTower.xml
+ E:\Nextcloud\Documents\Openstreetmap\JOSM presets\motorway_link.xml
+ E:\Nextcloud\Documents\Openstreetmap\JOSM presets\TunnelLayerPreset.xml
+ E:\Nextcloud\Documents\Openstreetmap\JOSM presets\BridgeLayerPreset.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

[skyper]

Have the same problem. Additionally, once the ways have the same child nodes distributing the nodes does not work anymore and always give the message about nothing to do.

[skyper]

example file for both problems (distribute on the right)

[GerdP]

Probably a regression of my recent changes

[GerdP]

Problem is not that the way is closed, but that there is no other node between those for the new arc.

[GerdP]

@skyper: I do not yet understand what you do and what you expect.
Edit: The file josm_19979_example.osm has an overlapping way. Was that intended?

[ff5722]

Replying to GerdP:

@skyper: I do not yet understand what you do and what you expect.
Edit: The file josm_19979_example.osm has an overlapping way. Was that intended?

When you select the triangle on the left, and then create circle way, you get what's on the right. The overlapping way is exactly the issue, creating a circle way should leave the rectangle untouched.

Problem is not that the way is closed, but that there is no other node between those for the new arc.

Yes this is correct, putting a temporary node between is a workaround.

[GerdP]

OK, now I understand. Another workaround is to select the nodes.

[skyper]

example version 2 with more info

[skyper]

Replying to ff5722:

Replying to GerdP:

@skyper: I do not yet understand what you do and what you expect.
Edit: The file josm_19979_example.osm has an overlapping way. Was that intended?

When you select the triangle on the left, and then create circle way, you get what's on the right. The overlapping way is exactly the issue, creating a circle way should leave the rectangle untouched.

Close, after "Create arc" I added some more nodes on the right.

Problem is not that the way is closed, but that there is no other node between those for the new arc.

Yes this is correct, putting a temporary node between is a workaround.

Thanks, yes, a workaround.

Sorry, for my short info. I attached an updated example file​ extending the ways and adding more info:

• on the left is the first issue with merging ways
• on the right is the outcome plus some more nodes (+) manually added.
  • there I would like to have the nodes distribute, one each of the two "halves", as long as all ways include all nodes in same/reverse order. Talking about new nodes (id=0), these could even be distributed along the whole arc and order be changed.

[GerdP]

@skyper: I think this is a completely different problem, please open a new ticket.

[GerdP]

In 35608/osm:

fix #19979 Circle arc behaves like merge

• fix collection of parent ways when only a way is selected
• fix memory leak

[GerdP]

In 35609/osm:

see #19979 Circle arc behaves like merge
dist

[skyper]

Replying to GerdP:

@skyper: I think this is a completely different problem, please open a new ticket.

see #19985.