#19930 closed defect (fixed)
Warning "oneway=yes is unnecessary for waterway" is incorrect; has lead to deletion of valid data
| Reported by: | Owned by: | team | |
|---|---|---|---|
| Priority: | normal | Milestone: | 20.11 |
| Component: | Core validator | Version: | latest |
| Keywords: | unnecessary tag false positive waterway oneway | Cc: |
Description
JOSM validator gives a warning for a waterway with the tag "oneway=yes".
This warning is incorrect: seamarks can be used to create a legal obligation to follow a certain direction just as on a highway.
And also from the point of waterflow waterways do no necessarily run in one direction; waterways here run in one direction or another, depending on the measures in water manegement
This validator rule leads to deletion of valid data from our database, so please delete this rule in next update, thanks!!
Example
Oneway for boats from survey: https://www.mapillary.com/map/im/iq5vgMIIa0aD2cMST9IlXA
This correct tag was added in v3 and deleted in v6 by a JOSM-user doing a type of building import (BAG ) for which the JOSM-validator is used.
Changeset:
https://www.openstreetmap.org/changeset/79200184
Way history:
https://osmlab.github.io/osm-deep-history/#/way/604073901
Attachments (0)
Change History (9)
comment:1 by , 4 years ago
| Keywords: | waterway oneway added |
|---|
comment:2 by , 4 years ago
| Milestone: | → 20.10 |
|---|---|
| Priority: | major → normal |
follow-up: 4 comment:3 by , 4 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
follow-up: 5 comment:4 by , 4 years ago
Replying to Klumbumbus:
In 17209/josm:
Thx! Does this mean that
-this tag isn't called "unnecessary" by the validator for navigable waterways anymore (also not on the "info level")?
-these tags can no longer be automatically deleted by pushing the "fix" button in the validator?
Best regards (-:
follow-up: 6 comment:5 by , 4 years ago
Replying to multimodaal <multimodaal@…>:
-this tag isn't called "unnecessary" by the validator for navigable waterways anymore (also not on the "info level")?
- non navigable waterway are in warning level with "oneway on suspicious object"
- navigable waterway are in info level with "waterway together with oneway. The flow direction is defined by the way direction. Use oneway on waterway only in the rare case of a access restriction." This is to help finding waterways where the flow direction was incorrectly tagged with the oneway key.
-these tags can no longer be automatically deleted by pushing the "fix" button in the validator?
yes the fix button is disabled in all these cases
comment:6 by , 4 years ago
Replying to Klumbumbus:
Perfect! thanks (-:
I also added to the wiki for Key:oneway
"Legal oneway restrictions for a mandatory direction of travel on waterways can be mapped with oneway= as well, for instance when signposted with a seamark or when this is part of legislation. For describing the direction of flow of water please consider different tags than this legal key oneway= "
https://wiki.openstreetmap.org/wiki/Key:oneway#On_waterways
comment:7 by , 4 years ago
comment:8 by , 4 years ago
thx, that's a good addition. I added a sentence for special cases with bi directional flow.
https://wiki.openstreetmap.org/w/index.php?title=Key%3Aoneway&type=revision&diff=2050138&oldid=2050137
In 17209/josm: