Context Navigation

Modify ↓

#19886 closed defect (fixed)

NoSuchElementException at MergeAddrPointsAction.actionPerformed

Reported by:	szydzio@…	Owned by:	GerdP
Priority:	normal	Milestone:
Component:	Plugin buildings_tools	Version:
Keywords:	template_report	Cc:	simon04

Description

What steps will reproduce the problem?

merging addresses with building outlines (building_tools plug in)

What is the expected result?

JOSM merges the addresses with buldings

What happens instead?

An error occurs saying the building_tool plug-in encounted an unexpected error
Clicking the button update the plug in produces an further error saying several other plug ins can not be found like Tracer2, reverter, opendata, etc.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-10-03 13:42:38 +0200 (Sat, 03 Oct 2020)
Revision:17084
Build-Date:2020-10-04 01:30:47
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17084 pl) Linux Ubuntu 18.04.5 LTS
Memory Usage: 1644 MB / 1962 MB (1245 MB allocated, but free)
Java version: 11.0.8+10-post-Ubuntu-0ubuntu118.04.1, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1366x768 (scaling 1.0x1.0)
Maximum Screen Size: 1366x768
Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32
Desktop environment: MATE
Java package: openjdk-11-jre:amd64-11.0.8+10-0ubuntu1~18.04.1
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-20ubuntu0.1
fonts-noto: fonts-noto:all-20171026-2
VM arguments: [--add-modules=java.scripting,java.sql, -Djosm.restart=true, -Djava.net.useSystemProxies=true]
Dataset consistency test: No problems found

Plugins:
+ Tracer2 (35499)
+ apache-commons (35524)
+ buildings_tools (35563)
+ ejml (35313)
+ geotools (35169)
+ jaxb (35092)
+ jts (35122)
+ opendata (35513)
+ reverter (35556)
+ utilsplugin2 (35487)

Last errors/warnings:
- 24762,258 E: Handled by bug report queue: java.util.NoSuchElementException
- 24777,395 W: Ostrzeżenie - <html>Nie można odnaleźć informacji o następujących wtyczkach:<ul><li>jaxb</li><li>utilsplugin2</li><li>apache-commons</li><li>geotools</li><li>opendata</li><li>jts</li><li>buildings_tools</li><li>ejml</li><li>Tracer2</li><li>reverter</li></ul>Wtyczki nie zostaną wczytane</html>
- 24787,501 E: Handled by bug report queue: java.util.NoSuchElementException
- 24809,082 W: Ostrzeżenie - <html>Nie można odnaleźć informacji o następujących wtyczkach:<ul><li>jaxb</li><li>utilsplugin2</li><li>apache-commons</li><li>geotools</li><li>opendata</li><li>jts</li><li>buildings_tools</li><li>ejml</li><li>Tracer2</li><li>reverter</li></ul>Wtyczki nie zostaną wczytane</html>


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (18) of main
java.util.NoSuchElementException
	at java.base/java.util.ArrayList$Itr.next(ArrayList.java:1000)
	at org.openstreetmap.josm.command.DeleteCommand.<init>(DeleteCommand.java:129)
	at org.openstreetmap.josm.plugins.buildings_tools.MergeAddrPointsAction.actionPerformed(MergeAddrPointsAction.java:176)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1967)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2308)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
	at java.desktop/javax.swing.AbstractButton.doClick(AbstractButton.java:369)
	at java.desktop/javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:1020)
	at java.desktop/javax.swing.plaf.basic.BasicMenuItemUI$Handler.menuDragMouseReleased(BasicMenuItemUI.java:1132)
	at java.desktop/javax.swing.JMenuItem.fireMenuDragMouseReleased(JMenuItem.java:575)
	at java.desktop/javax.swing.JMenuItem.processMenuDragMouseEvent(JMenuItem.java:472)
	at java.desktop/javax.swing.JMenuItem.processMouseEvent(JMenuItem.java:417)
	at java.desktop/javax.swing.MenuSelectionManager.processMouseEvent(MenuSelectionManager.java:342)
	at java.desktop/javax.swing.plaf.basic.BasicPopupMenuUI$MouseGrabber.eventDispatched(BasicPopupMenuUI.java:903)
	at java.desktop/java.awt.Toolkit$SelectiveAWTEventListener.eventDispatched(Toolkit.java:2198)
	at java.desktop/java.awt.Toolkit$ToolkitEventMulticaster.eventDispatched(Toolkit.java:2090)
	at java.desktop/java.awt.Toolkit.notifyAWTEventListeners(Toolkit.java:2046)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4917)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2321)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4918)
	at java.desktop/java.awt.LightweightDispatcher.processMouseEvent(Container.java:4547)
	at java.desktop/java.awt.LightweightDispatcher.dispatchEvent(Container.java:4488)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2307)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2772)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4843)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:772)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:95)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745)
	at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:743)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

Attachments (2)

error_1.png (24.4 KB ) - added by szydzio@… 4 years ago.
error_2.png (19.0 KB ) - added by szydzio@… 4 years ago.

Download all attachments as: .zip

Change History (12)

by szydzio@…, 4 years ago

Attachment:	error_1.png added

by szydzio@…, 4 years ago

Attachment:	error_2.png added

comment:1 by GerdP, 4 years ago

Component:	Core → Plugin buildings_tools
Owner:	changed from team to GerdP
Status:	new → assigned

Probably a regression from [35563/osm]

comment:2 by GerdP, 4 years ago

I can reproduce it with a selection containing a way building=yes and a node with addr:housenumber=1 that is not inside the selected building.

Last edited 4 years ago by GerdP (previous) (diff)

comment:3 by Don-vip, 4 years ago

Summary:	JOSM 17084 error → NoSuchElementException at MergeAddrPointsAction.actionPerformed

comment:4 by GerdP, 4 years ago

In 35570/osm:

see #19886: NoSuchElementException at MergeAddrPointsAction.actionPerformed

add check for empty list

comment:5 by GerdP, 4 years ago

In 35571/osm:

see #19886: NoSuchElementException at MergeAddrPointsAction.actionPerformed
dist

comment:6 by GerdP, 4 years ago

The 2nd problem regarding

an further error saying several other plug ins can not be found like Tracer2, reverter, opendata, etc.

probably needs to be fixed in JOSM core

comment:7 by GerdP, 4 years ago

@Don-vip: In PluginHandler we have

            task1.run();
            List<PluginInformation> allPlugins = task1.getAvailablePlugins();

Since task1.run(); is typically not yet ready when the next line is executed this fails.

comment:8 by Don-vip, 4 years ago

Cc:	simon04 added

Introduced in r8776. Indeed we should wait for task completion.

comment:9 by GerdP, 4 years ago

Resolution:	→ fixed
Status:	assigned → closed

problem in plugin is fixed, for the update of plugins see #19098

comment:10 by simon04, 4 years ago

Damn, what was I doing back in 2015 inside r8776!? I no longer recall…

Modify Ticket

Change Properties

Summary:
Type:		Priority:
Milestone:		Component:
Version:		Keywords:
Cc:	Set your email in Preferences

Action

leave as closed The owner will remain GerdP.

change resolution as The resolution will be set.

reopen The resolution will be deleted. Next status will be 'reopened'.

Add Comment

Your email or username:

E-mail address and name can be saved in the Preferences .

You may use WikiFormatting here.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.

Download in other formats:

Context Navigation

#19886 closed defect (fixed)

NoSuchElementException at MergeAddrPointsAction.actionPerformed

Description

What steps will reproduce the problem?

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Attachments (2)

Change History (12)

by szydzio@…, 4 years ago

by szydzio@…, 4 years ago

comment:1 by GerdP, 4 years ago

comment:2 by GerdP, 4 years ago

comment:3 by Don-vip, 4 years ago

comment:4 by GerdP, 4 years ago

comment:5 by GerdP, 4 years ago

comment:6 by GerdP, 4 years ago

comment:7 by GerdP, 4 years ago

comment:8 by Don-vip, 4 years ago

comment:9 by GerdP, 4 years ago

comment:10 by simon04, 4 years ago

Modify Ticket

Add Comment

by anonymous

Download in other formats: