Modify ↓
Opened 4 years ago
Last modified 23 months ago
#19764 new enhancement
Nice message about closing already closed note
| Reported by: | mkoniecz | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core notes | Version: | |
| Keywords: | template_report | Cc: |
Description
What steps will reproduce the problem?
- Create note
- Download note with JOSM
- Close note on OSM website
- Close note in JOSM
- Upload nodes from JOSM
What is the expected result?
JOSM either reports nothing (as note was closed anyway) or reports situation in a clear nonscary way.
What happens instead?
User gets a scary message (message with an error icon and "nodes failed to upload title", direct dump of error message including mentions of 409 error code and so on)
Please provide any additional information below. Attach a screenshot if possible.
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2020-08-07 18:58:40 +0200 (Fri, 07 Aug 2020) Revision:16853 Build-Date:2020-08-08 01:30:49 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (16853 en_GB) Linux Ubuntu 20.04.1 LTS Memory Usage: 306 MB / 976 MB (111 MB allocated, but free) Java version: 11.0.8+10-post-Ubuntu-0ubuntu120.04, Ubuntu, OpenJDK 64-Bit Server VM Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel Screen: :0.0 1366x768 (scaling 1.0x1.0) Maximum Screen Size: 1366x768 Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32 Java package: openjdk-11-jre:amd64-11.0.8+10-0ubuntu1~20.04 Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1 libcommons-logging-java: libcommons-logging-java:all-1.2-2 fonts-noto: fonts-noto:- Dataset consistency test: No problems found Plugins: + buildings_tools (35500) + measurement (35405) + reverter (35499) + todo (30306) Last errors/warnings: - E: Conflict - <html>The server reported that it has detected a conflict.<br>Error message (untranslated):<br>The note 2337951 was closed at 2020-09-06 19:09:04 UTC</html> - E: Error header: The note 2337951 was closed at 2020-09-06 19:09:04 UTC - E: Failed to upload note to server: 2 337 951 - E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=409, Error Header=<The note 2337951 was closed at 2020-09-06 19:09:04 UTC> - E: Error header: The note 2337950 was closed at 2020-09-06 19:09:10 UTC - E: Failed to upload note to server: 2 337 950 - E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=409, Error Header=<The note 2337950 was closed at 2020-09-06 19:09:10 UTC> - E: Notes failed to upload: Note 2 337 951 failed: ResponseCode=409, Error Header=<The note 2337951 was closed at 2020-09-06 19:09:04 UTC> - E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=409, Error Header=<The note 2337951 was closed at 2020-09-06 19:09:04 UTC> - E: Conflict - <html>The server reported that it has detected a conflict.<br>Error message (untranslated):<br>The note 2337951 was closed at 2020-09-06 19:09:04 UTC</html>
Attachments (0)
Change History (3)
comment:1 by , 4 years ago
| Component: | Core → Core notes |
|---|
comment:2 by , 23 months ago
comment:3 by , 23 months ago
We should probably handle the response codes 409 (conflict) and 410 (gone).
In the first case, we should
- Update the note (
/api/0.6/notes/#id) - Ask the user if their comment(s) are still relevant
In the second case, we should
- Tell the user the note no longer exists
- Ask the user if they want to create a new note with their comment(s)
- Delete the original note from the note layer
Note:
See TracTickets
for help on using tickets.
#21668 is similar.