Modify ↓

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#19752 closed enhancement (fixed)

[Patch] StyleCache.intern: use HashMap instead of Storage

Reported by: simon04 Owned by: simon04
Priority: normal Milestone: 20.11
Component: Core Version:
Keywords: yourkit performance intern hashmap Cc:

Description (last modified by simon04)

  1. Start JOSM
  2. Install pbf plugin
  3. Open montenegro-latest.osm.pbf

Time spent in StyleCache.intern is reduced from 13_919 ms to 926 ms.

"Merged Call Tree","Time Diff (ms)","Old Time (ms)","New Time (ms)","Level"
"org.openstreetmap.josm.gui.mappaint.StyleCache.intern() StyleCache.java","-12992","13919","926","1"
"java.util.HashMap.computeIfAbsent(Object, Function) HashMap.java","916","0","916","2"
"org.openstreetmap.josm.data.osm.Storage.putUnique(Object) Storage.java","-13648","13648","0","2"

Attachments (1)

19752.patch​ (2.4 KB ) - added by simon04 4 years ago.

Download all attachments as: .zip

Change History (5)

by simon04, 4 years ago

Attachment: 19752.patch​ added

comment:1 by simon04, 4 years ago

Description: modified (diff)

comment:2 by Don-vip, 4 years ago

Milestone: 20.09 → 20.10

comment:3 by simon04, 4 years ago

Resolution: → fixed
Status: assigned → closed

In 17101/josm:

fix #19752 - StyleCache.intern: use HashMap instead of Storage

comment:4 by Don-vip, 4 years ago

Milestone: 20.10 → 20.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.