[PATCH] Visually differentiate barrier=city_wall left and right sides

[gaben]

According to the ​wiki:
"Behaves same as natural=cliff, that is no crossing as left-right are different height. Lower side on right side of way direction.."

Currently, in JOSM, the left and right sides are not differentiated visually.

[skyper]

Needs to be added for special handling to the revert way action, too.

[Klumbumbus]

In 16938/josm:

• fix #19714 - Add rendering of right side of barrier=city_wall
• Add two_sided=yes checkbox to barrier=city_wall preset
• Fix unpredictable rendering of patterns

[Klumbumbus]

Replying to skyper:

Needs to be added for special handling to the revert way action, too.

Oh, I didn't see your comment.

[Klumbumbus]

In 16939/josm:

• see #19714 - Warn if barrier=city_wall way is reversed

[Klumbumbus]

I don't know how to exclude the special case when two_sided=yes is tagged (regarding the way reverse warning).

[gaben]

Replying to Klumbumbus:

I don't know how to exclude the special case when two_sided=yes is tagged (regarding the way reverse warning).

Probably an extra check around here: https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/actions/corrector/ReverseWayNoTagCorrector.java?rev=16939#L58
It would be ugly but could work.

[Klumbumbus]

I tried that already but failed with my "copy paste java knowledge" :D

[stoecker]

Please explain what needs to be done (also related to the other tags of the tag corrector).

[skyper]

So far the code only checks for single tags, only, but in cases of barrier=city_wall together with two_sided=yes there should be no warning. So we need the possibility to exclude this combination.

[gaben]

I did a bit of research. Although the two_sided=yes attribute used mostly only on city_walls but also on guard_rails, walls, kerbs and a few more. City_wall has over 4k, others <100 occurrences. I have a patch for city_wall only. Is it enough?

[skyper]

Replying to gaben:

I did a bit of research. Although the two_sided=yes attribute used mostly only on city_walls but also on guard_rails, walls, kerbs and a few more. City_wall has over 4k, others <100 occurrences. I have a patch for city_wall only. Is it enough?

Think patches are always welcome. Is it possible, to exclude two_sided=yes, in general, no matter what the additional tags are? Are there any use cases where reverting the way directions is a problem?

[gaben]

Ignore directional ways which have two_sided=yes tag

[gaben]

Replying to skyper:

Is it possible, to exclude two_sided=yes, in general, no matter what the additional tags are?

Absolutely. It's the easiest solution :)

Are there any use cases where reverting the way directions is a problem?

The patch only affects ways, which are directional + have two_sided=yes tag. So probably not a problem.

[stoecker]

In 17023/josm:

fix #19714, patch by gaben, don't complain about direction reversal in case of two_sided=yes

[gaben]

Ah sorry, the ticket reference in the comment got an extra 0 at the end :(

-// two_sided=yes is a special (documented) barrier=city_wall attribute, see #197140
+// two_sided=yes is a special (documented) barrier=city_wall attribute, see #19714

source:trunk/src/org/openstreetmap/josm/actions/corrector/ReverseWayNoTagCorrector.java?rev=17023#L62​

[Klumbumbus]

In 17029/josm:

• see #19726 - Unify changeset icon, use globe icon in history window version table popup menu, as it opens in the browser
• see #19714 - Typo in comment

[gaben]

Thanks! :)