[PATCH] Move `apache-http` to the `ivy` dependency system

[taylor.smock]

The first attached patch adds apache-logging as well. I feel that this should be in apache-commons, and that will be in two (separately labeled) patches.

apache-logging is required since apache-http makes calls to apache-logging. This issue has been encountered during Mapillary and MapWithAI development.

IMO, it makes more sense to put apache-logging in apache-commons instead of apache-http. Alternatively, another plugin could be made (probably not the best idea).

[taylor.smock]

Apache HTTP with logging (and IVY)

[taylor.smock]

Apache HTTP without logging (but still with IVY)

[taylor.smock]

Add Apache Commons Logging to apache-commons

[stoecker]

Ah sorry, Vincent isn't active ATM. If I understand right the second and third patch should be applied?

[taylor.smock]

I kind of figured that Vincent was not active (I haven't seen anything from him in the general changelog for quite some time). I was kind of figuring that I would probably have to go back through patches on components that he is responsible for when he becomes active again, and just pinging it or something.

As far as the patches go, attachment:19562.apache_http_without_logging.patch​ and attachment:19562.apache_commons_logging.patch​ are the ones that I felt would make the most sense, yes.

[stoecker]

In 35520/osm:

see #19562 - add logging to apache commons

[stoecker]

Hmm, that ivy stuff is still broken for me in plugins:

download-ivy:
      [get] Getting: https://josm.openstreetmap.de/nexus/content/repositories/public/org/apache/ivy/ivy/2.4.0-local-19691228075642/ivy-2.4.0-local-19691228075642.jar
      [get] To: /home/stoecker/.ant/lib/ivy.jar
      [get] Error opening connection java.io.FileNotFoundException: https://josm.openstreetmap.de/nexus/content/repositories/public/org/apache/ivy/ivy/2.4.0-local-19691228075642/ivy-2.4.0-local-19691228075642.jar
      [get] Error opening connection java.io.FileNotFoundException: https://josm.openstreetmap.de/nexus/content/repositories/public/org/apache/ivy/ivy/2.4.0-local-19691228075642/ivy-2.4.0-local-19691228075642.jar
      [get] Error opening connection java.io.FileNotFoundException: https://josm.openstreetmap.de/nexus/content/repositories/public/org/apache/ivy/ivy/2.4.0-local-19691228075642/ivy-2.4.0-local-19691228075642.jar
      [get] Can't get https://josm.openstreetmap.de/nexus/content/repositories/public/org/apache/ivy/ivy/2.4.0-local-19691228075642/ivy-2.4.0-local-19691228075642.jar to /home/stoecker/.ant/lib/ivy.jar

BUILD FAILED
/home/stoecker/sources/josm/plugins/build-common.xml:709: Can't get https://josm.openstreetmap.de/nexus/content/repositories/public/org/apache/ivy/ivy/2.4.0-local-19691228075642/ivy-2.4.0-local-19691228075642.jar to /home/stoecker/.ant/lib/ivy.jar

I was kind of figuring that I would probably have to go back through patches on components that he is responsible for when he becomes active again, and just pinging it or something.

No, if somebody isn't available we'll go on and hope he/she comes back :-)

[taylor.smock]

@stoecker: As far as broken ivy stuff goes, have you made any modifications to any build.xml files (including the build-common.xml) where the ivy version is specified? I don't know why else it would be trying to get 2.4.0-local-19691228075642 (we only have 2.4.0 and 2.5.0 on the JOSM nexus).

No, if somebody isn't available we'll go on and hope he/she comes back :-)

It is a little more difficult if you don't know who else to ping. :)

[stoecker]

Replying to taylor.smock:

@stoecker: As far as broken ivy stuff goes, have you made any modifications to any build.xml files (including the build-common.xml) where the ivy version is specified? I don't know why else it would be trying to get 2.4.0-local-19691228075642 (we only have 2.4.0 and 2.5.0 on the JOSM nexus).

Probably this comes from the system installation?:

apache-ivy-2.4.0-6.3.noarch
ivy-local-5.3.0-3.1.noarch

I don't have any modifications. That's a plain fresh checkout.

[simon04]

Did you override the ivy.version property? What about running…

$ ant -Divy.version=2.5.0 clean dist

[stoecker]

Replying to simon04:

Did you override the ivy.version property? What about running…

No.

$ ant -Divy.version=2.5.0 clean dist

That works. Can we adapt the SVN so that it works from scratch?

[stoecker]

In 35523/osm:

improve ivy support, see #19562

[simon04]

@stoecker: In plugins/build-common.xml we have the task fetch_dependencies. Can we make use of that
one instead of resolve task from plugins/apache-http?

[stoecker]

I have no idea. I don't know any details of that ivy stuff.

[simon04]

https://josm.openstreetmap.de/changeset/35524/osm