Opened 16 years ago
Closed 15 years ago
#1954 closed defect (fixed)
[Patch?] WMS layer display caching broken
| Reported by: | anonymous | Owned by: | framm |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | Plugin | Version: | |
| Keywords: | Cc: |
Description
The speed of WMS layer indicates, that it is redrawn always. When no zoom action has been done, the layer should not be redrawn or a double buffering should be used.
Also disabled WMS layers seem to have wrong information of zoom level when reactivated and refuse downloading (when size before disabling was to big).
Attachments (3)
Change History (10)
by , 15 years ago
| Attachment: | CacheResizedImageInMemory.patch added |
|---|
comment:1 by , 15 years ago
| Summary: | WMS layer: reduce redrawing → [PATCH] WMS layer: reduce redrawing |
|---|
comment:2 by , 15 years ago
| Summary: | [PATCH] WMS layer: reduce redrawing → WMS layer does not update zoom level after beeing disabled |
|---|
Applied but not yet uploaded as plugin.
by , 15 years ago
| Attachment: | FixCrashBug.patch added |
|---|
comment:3 by , 15 years ago
| Summary: | WMS layer does not update zoom level after beeing disabled → [PATCH] WMS layer does not update zoom level after beeing disabled |
|---|
Apparently the intersectsClip path can be hit after all (if tiles are loaded, view is moved somewhere else and you zoom.).
The crash fix is really simple and should be checked in soon because if it occurs you can only kill JOSM.
comment:4 by , 15 years ago
| Summary: | [PATCH] WMS layer does not update zoom level after beeing disabled → WMS layer display caching broken |
|---|
OK. Applied. Now we have a different problem. When loading e.g. LandSat I see wrong tiles during loading which are corrected when doing a zoom. Thus I think the display cache somehow does not invalidate all old caching information.
comment:5 by , 15 years ago
Hm, cannot reproduce, but I'll investigate. #2164 (see my last comment) seems also worth be fixing
by , 15 years ago
| Attachment: | WMS Invalidate.patch added |
|---|
Delete cached copy whenever there are changes being made to GeoRefImage.image
comment:6 by , 15 years ago
| Summary: | WMS layer display caching broken → [Patch?] WMS layer display caching broken |
|---|
Please check if this fixes your problem. It now flushes the cached image whenever the normal image is changed.
This speeds up WMS drawing by quite a lot at the cost of increased memory usage. It caches the resized WMS image in memory and ignores pixel fluctuations if they don't cause artifacts.
This speeds up things quite a lot and even makes the helper line not lag behind while drawing. Zooming is still slow because of the unavoidable resize.