#19370 closed task (fixed)
Enable GitHub Actions
Reported by: | simon04 | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 21.02 |
Component: | Unit tests | Version: | |
Keywords: | github ci ex-longterm | Cc: | Stereo |
Description
Follow-up of ticket:18319#comment:29
Work in progress: https://github.com/openstreetmap/josm/pull/59
Attachments (1)
Change History (28)
comment:1 by , 5 years ago
comment:2 by , 5 years ago
Owner: | changed from | to
---|---|
Status: | assigned → new |
follow-up: 6 comment:3 by , 5 years ago
Really interesting, thank you! Both macOS and windows seem to fail on very similar things, and some of those do seem to be actual bugs.
I can't commit to that PR, so working on it will certainly get a bit tedious. How should we do it?
comment:4 by , 5 years ago
It also looks like the non-headless tests could run on macOS if we want them to.
comment:5 by , 5 years ago
To make the github action faster, we can use the cache action to cache ~/.ivy2/cache/
to keep these:
extract-libraries: [unzip] Expanding: /Users/stereo/.ivy2/cache/ch.poole/OpeningHoursParser/jars/OpeningHoursParser-0.21.4.jar into /Users/stereo/Documents/code/josm/build [unzip] Expanding: /Users/stereo/.ivy2/cache/com.adobe.xmp/xmpcore/jars/xmpcore-6.1.10.jar into /Users/stereo/Documents/code/josm/build [unzip] Expanding: /Users/stereo/.ivy2/cache/com.drewnoakes/metadata-extractor/jars/metadata-extractor-2.13.0.jar into /Users/stereo/Documents/code/josm/build [unzip] Expanding: /Users/stereo/.ivy2/cache/javax.json/javax.json-api/bundles/javax.json-api-1.1.4.jar into /Users/stereo/Documents/code/josm/build [unzip] Expanding: /Users/stereo/.ivy2/cache/oauth.signpost/signpost-core/jars/signpost-core-2.0.0.jar into /Users/stereo/Documents/code/josm/build [unzip] Expanding: /Users/stereo/.ivy2/cache/org.apache.commons/commons-compress/jars/commons-compress-1.20.jar into /Users/stereo/Documents/code/josm/build [unzip] Expanding: /Users/stereo/.ivy2/cache/org.apache.commons/commons-jcs3-core/jars/commons-jcs3-core-3.0-SNAPSHOT.jar into /Users/stereo/Documents/code/josm/build [unzip] Expanding: /Users/stereo/.ivy2/cache/org.glassfish/javax.json/bundles/javax.json-1.1.4.jar into /Users/stereo/Documents/code/josm/build [unzip] Expanding: /Users/stereo/.ivy2/cache/org.openstreetmap.jmapviewer/jmapviewer/jars/jmapviewer-2.14.jar into /Users/stereo/Documents/code/josm/build [unzip] Expanding: /Users/stereo/.ivy2/cache/org.tukaani/xz/jars/xz-1.8.jar into /Users/stereo/Documents/code/josm/build [unzip] Expanding: /Users/stereo/.ivy2/cache/org.webjars.npm/tag2link/jars/tag2link-2020.5.16.jar into /Users/stereo/Documents/code/josm/build
follow-up: 9 comment:6 by , 5 years ago
Replying to Stereo:
I can't commit to that PR, so working on it will certainly get a bit tedious. How should we do it?
Can you open a new pull request (starting from a branch of your JOSM fork)? If you allow "edits from maintainers", we both can work on that PR.
comment:7 by , 5 years ago
Test failing on my Mac – attachment:test-failure-error-macOS.tar.xz
A bunch of the failures seem to be related to the used locale (en_US vs. en_?). This causes various strings to differ.
comment:8 by , 5 years ago
Milestone: | 20.06 → Longterm |
---|
comment:9 by , 5 years ago
Replying to simon04:
Replying to Stereo:
I can't commit to that PR, so working on it will certainly get a bit tedious. How should we do it?
Can you open a new pull request (starting from a branch of your JOSM fork)? If you allow "edits from maintainers", we both can work on that PR.
I've opened https://github.com/openstreetmap/josm/pull/60.
I've also messaged you on Matrix to make it easier to work together, but am also on Telegram and the OSMF US Slack if you'd like.
comment:11 by , 5 years ago
Cool!
The whole JOSM.app in native
is now unnecessary, and can be deleted.
Now the next step should be changing the release mechanism to use this too - otherwise the August build won't be created.
Then we should change the script so that it still can still build and uploads an unsigned .app if it doesn't have the necessary secrets in the environment variables.
After that, it could be to fix the unit tests, and tell github to only build JOSM.app if the tests pass.
Finally, it could be finding a way of avoiding the way github will produce josm.zip.zip, which is https://github.com/actions/upload-artifact/issues/39
comment:13 by , 5 years ago
Seems the changes in r16776 cause problem with Jenkins build?
https://josm.openstreetmap.de/jenkins/job/JOSM/jdk=JDK8/6625/console
comment:15 by , 4 years ago
Something is not right, all GitHub Action tasks fail (independent of the Java version and the OS): https://github.com/openstreetmap/josm/actions
comment:22 by , 4 years ago
There's plenty of activity going on in https://github.com/thomersch/josm/commits/master
@Stereo, would you please link to relevant changes in order to update the GitHub CI configuration of https://github.com/openstreetmap/josm. It's worthless to debug and fix various issues (deprecation warnings) independently.
comment:24 by , 4 years ago
Shouldn't the milestone be set to 21.02
and add the keyword ex-longterm
instead of simply closing a longterm
?
comment:25 by , 4 years ago
Milestone: | Longterm → 21.02 |
---|
It was spread out over a few months, but I guess we can claim victory now.
Doesn't it feel nicer to close a longterm issue? :)
comment:26 by , 4 years ago
Keywords: | ex-longterm added |
---|
comment:27 by , 4 years ago
Yes, but if you could add an issue to Previous Longterm tickets it also feels good.
Everything except for ubuntu-latest with headless=true fails: https://github.com/openstreetmap/josm/actions/runs/132213807