Modify ↓

Opened 4 years ago

Closed 4 years ago

#19366 closed enhancement (fixed)

[PATCH] Add filter box for Color Preferences

Reported by: taylor.smock Owned by: team
Priority: normal Milestone: 20.06
Component: Core Version:
Keywords: Cc:

Description (last modified by taylor.smock)

This just makes it slightly easier to find a color to change.

What this patch does:

  • Adds a filter field
  • Adds a toString method in ColorEntry. This calls super.toString and appends the getDisplay() string to it.

Attachments (2)

19366.patch​ (2.1 KB ) - added by taylor.smock 4 years ago.
Add a filter field along with a toString method (calls super.toString and then appends the display name of the color).
19366.bug_fixes.patch​ (1.9 KB ) - added by taylor.smock 4 years ago.
The methods were calling table methods instead of model methods. This caused a row mismatch when filters were applied.

Download all attachments as: .zip

Change History (8)

comment:1 by taylor.smock, 4 years ago

Description: modified (diff)

by taylor.smock, 4 years ago

Attachment: 19366.patch​ added

Add a filter field along with a toString method (calls super.toString and then appends the display name of the color).

comment:2 by simon04, 4 years ago

Resolution: → fixed
Status: new → closed

In 16594/josm:

fix #19366 - Add filter box for Color Preferences (patch by taylor.smock, modified)

comment:3 by simon04, 4 years ago

Milestone: → 20.06

Thanks. I modified your patch – When using a TableSorter, always use convertRowIndexToModel() to map the index. In the past, this caused various bugs in various tables.

comment:4 by Klumbumbus, 4 years ago

Nice.

in reply to:  3 comment:5 by taylor.smock, 4 years ago

Resolution: fixed
Status: closed → reopened

by taylor.smock, 4 years ago

Attachment: 19366.bug_fixes.patch​ added

The methods were calling table methods instead of model methods. This caused a row mismatch when filters were applied.

comment:6 by simon04, 4 years ago

Resolution: → fixed
Status: reopened → closed

In 16607/josm:

fix #19366 - ColorPreference: fix setting colors when sorting is active

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.