Context Navigation

Modify ↓

#19354 closed enhancement (fixed)

UndoRedoHandler.getUndoCommands: return unmodifiable list

Reported by:	simon04	Owned by:	team
Priority:	normal	Milestone:	20.06
Component:	Core	Version:
Keywords:	refactoring	Cc:	taylor.smock

Description

Avoids unnecessary list creation.

src/org/openstreetmap/josm/data/UndoRedoHandler.java

diff --git a/src/org/openstreetmap/josm/data/UndoRedoHandler.java b/src/org/openstreetmap/josm/data/UndoRedoHandler.java
index 239693b43..c930656a7 100644

-              a
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.data;
+import java.util.Collections;
 import java.util.EventObject;
 import java.util.LinkedList;
 import java.util.List;
-…
+               void fire(CommandQueuePreciseListener listener) {
      * @return all commands that were made on the dataset, that can be undone
      * @since 14281
      */
     public LinkedList<Command> getUndoCommands() {
         return new LinkedList<>(commands);
+    public List<Command> getUndoCommands() {
+        return Collections.unmodifiableList(commands);
+    }
     /**
-…
+               void fire(CommandQueuePreciseListener listener) {
      * @return all commands that were made and undone on the dataset, that can be redone.
      * @since 14281
      */
     public LinkedList<Command> getRedoCommands() {
         return new LinkedList<>(redoCommands);
+    public List<Command> getRedoCommands() {
+        return Collections.unmodifiableList(redoCommands);
+    }
     /**