Modify

Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#19340 closed defect (fixed)

[patch] Validator complains about maxweightrating:X:conditional

Reported by: jengelh@… Owned by: GerdP
Priority: normal Milestone: 22.09
Component: Core validator Version:
Keywords: Cc:

Description

way 26788123 has set

maxweightrating:hgv:conditional="no @ agricultural;no @ forestry;no @ bus"
maxweightrating:hgv=7.5

Validator of JOSM 16239 complains:

"Wrong syntax in maxweightrating:hgv:conditional key (1)"
TestError [tester=org.openstreetmap.josm.data.validation.tests.ConditionalKeys@2bbbf1c6, code=3201, message=Wrong syntax in maxweightrating:hgv:conditional key]

But it does not say how to improve it.

Attachments (0)

Change History (3)

comment:1 by GerdP, 2 years ago

Owner: changed from team to GerdP
Status: newassigned
Summary: Validator complains about maxweightrating:X:conditional[patch] Validator complains about maxweightrating:X:conditional

If nobody complains I'll commit this patch next monday:

  • src/org/openstreetmap/josm/data/validation/tests/ConditionalKeys.java

     
    2727    private final OpeningHourTest openingHourTest = new OpeningHourTest();
    2828    private static final Set<String> RESTRICTION_TYPES = new HashSet<>(Arrays.asList("oneway", "toll", "noexit", "maxspeed", "minspeed",
    2929            "maxstay", "maxweight", "maxaxleload", "maxheight", "maxwidth", "maxlength", "overtaking", "maxgcweight", "maxgcweightrating",
    30             "fee", "restriction", "interval", "duration", "dog"));
     30            "fee", "restriction", "interval", "duration", "dog", "maxweightrating"));
    3131    private static final Set<String> RESTRICTION_VALUES = new HashSet<>(Arrays.asList("yes", "official", "designated", "destination",
    3232            "delivery", "customers", "permissive", "private", "agricultural", "forestry", "no"));
    3333    private static final Set<String> TRANSPORT_MODES = new HashSet<>(Arrays.asList("access", "foot", "ski", "inline_skates", "ice_skates",
Last edited 2 years ago by GerdP (previous) (diff)

comment:2 by GerdP, 2 years ago

Resolution: fixed
Status: assignedclosed

In 18560/josm:

fix #19340: Validator complains about maxweightrating:X:conditional

  • add maxweightrating as valid keyword

comment:3 by taylor.smock, 2 years ago

Milestone: 22.09

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.