Download as new layer not respected if new_layer=false is present

[skyper]

What steps will reproduce the problem?

1. In preferences enable "Download as new layer"
2. Click on a "remote control link" in web browser
   Edit: link including new_layer=false, like GET /load_object?new_layer=false&relation_members=true&objects=r7367864 HTTP/1.1

What is the expected result?

It is downloaded to a new layer

What happens instead?

It is downloaded to active layer

Please provide any additional information below. Attach a screenshot if possible.

Edit: So, the local setting should overwrite/change the command.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-05-27 21:23:59 +0200 (Wed, 27 May 2020)
Revision:16511
Build-Date:2020-05-28 01:30:47
URL:https://josm.openstreetmap.de/svn/trunk

[simon04]

I cannot reproduce.

1. Enable "Download as new layer"
2. Add layer (Data Layer 1), draw some lines
3. GET /load_and_zoom?left=-59.89047185907365&top=-36.75424350001947&right=-59.885985689067844&bottom=-36.75801721796789
4. Observe that download has created Data Layer 2

Revision:16538
Is-Local-Build:true
Build-Date:2020-06-02 21:43:46

[skyper]

Oh, sorry, the problem is the presence of new_layer=false like in GET /load_object?new_layer=false&relation_members=true&objects=r7367864 HTTP/1.1. Should probably, be overwritten by local settings to GET /load_object?new_layer=true&relation_members=true&objects=r7367864 HTTP/1.1.

I've adjusted the description.

[simon04]

Actually, this is what I'd expect and consider as correct: The preference defines the default behaviour which can be overridden by the request parameter.

[skyper]

From the user's point of few, I have not much influence on the request parameter on a website, but the preferences are the user's choice.

I can ask each admin of the websites, individually, to drop the parameter, or the user's preferences are dominant and overwrite the parameters. See also #19307 which would make it even more user friendly.

[skyper]

Is new_layer=false the default, e.g. can it simply be omitted ?

[simon04]

• new_layer=false → no new layer
• new_layer=true → new layer
• new_layer absent → take "Download as new layer" preference

[skyper]

Ok, thanks. So there is not much reason to add new_layer=false but to overwrite the users settings.

[ToniE]

I can ask each admin of the websites, ...

I'm one of the admins: I did not want to override any user settings by using new_layer=false

new_layer absent → take "Download as new layer" preference

Fine for me.

[skyper]

I added the information to the wiki, wiki:/Help/RemoteControlCommands?&action=diff&version=14&old_version=13.

Still, I would prefer to have it upside down and always respect the user's preference.

[ToniE]

+1

[simon04]

Basically, you're asking for a setting "Download as new layer"

• default yes (used when new_layer absent)
• default no (used when new_layer absent)
• always yes (overrides new_layer)
• always no (overrides new_layer)
• ask me every time?

[skyper]

Replying to simon04:

Basically, you're asking for a setting "Download as new layer"

yes.

• default yes (used when new_layer absent)
• default no (used when new_layer absent)

These two cases are the status quo but are they really needed if the following three work?

• always yes (overrides new_layer)

That's what I'd expected to get with the user preference setting.

• always no (overrides new_layer)

Did not think about this case but it makes sense.

• ask me every time?

Can be handled together with confirmation dialog.