Select all inside: Child Nodes of inside ways not selected

[skyper]

What steps will reproduce the problem?

1. Have a polygon with a way with some child nodes inside, see josm_all_inside_small_example.osm​.
2. Select polygon
3. "All inside" from selection menu

What is the expected result?

All object inside the polygon are selected

What happens instead?

Child nodes of ways inside the polygon are not selected

Please provide any additional information below. Attach a screenshot if possible.

Other nodes are selected

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-05-21 00:29:30 +0200 (Thu, 21 May 2020)
Revision:16472
Build-Date:2020-05-21 01:30:46
URL:https://josm.openstreetmap.de/svn/trunk

Plugins:
+ utilsplugin2 (35468)

[skyper]

small example

[GerdP]

It would be ease to change that, but it seems this is intended. See also[o30200]
There is a flag ignoreNodesOfFoundWays which is set to true for the action. No idea why.
If you use search (Ctrl+F) with inside you get what you want.

[skyper]

It is easier to deselect child nodes than to additional select them.
The flag should be a setting.
With search I should get all possible selections.
I would expect that the same functions are used but I do not know what was implemented first.

We need to document the action to state what the result of the action should be.

[GerdP]

I looked at the svn history. I think [o26644] introduced the select all inside action and my understanding of the code is that nodes and ways were selected in this version. [o30200] changed it.
I assume that change wasn't intended as the comment only mentions that the search finds nodes and ways, so I'd be happy to change the code for the action to find nodes and ways again.

[GerdP]

In 35613/osm:

fix #19280 Select all inside: Child Nodes of inside ways not selected

• change parameter for selectAllInside() to select nodes in ways
• don't filter nodes in method addAllInsideMultipolygon(), let selectAllInside() decide if nodes are wanted

[GerdP]

In 35614/osm:

see #19280 Select all inside: Child Nodes of inside ways not selected
dist