[PATCH] MapRendererPerformanceTest does not render as intended anymore

[johsin18]

MapRendererPerformanceTest.testPerformanceDrawFeatures has two major problems (as of revision 16390).

• Lines are not drawn at all.
• The code tries to draw multiple variants, one with all features, one with just icons, one with just lines, and so on. However, currently, all variants results in the same output (namely having all features, except for the lines, as stated above).
• Overall, it draws as depicted in screenshot

I provide not status report as I have found clear bugs in the code already.

[johsin18]

all features after fix

[johsin18]

just icons, after fix

[johsin18]

The problems are caused by two things.
The map paint cache is not invalidated after switching the styles, so all variants are drawn like the first one (with all features).
viewWidth and viewHeight of MapViewState stay 0, so all lines are clipped.

The attached patch fixes those problems. However, the patch for the second problem is quite intrusive (overriding setBounds), so there might be better ways of doing it.
In addition, some minor issues are fixed as well.

See the changes commit by commit here:
​https://github.com/johsin18/josm/commits/fix-MapRendererPerformanceTest

As the map segment is different now (centered on downtown, seems more reasonable), and all features are actually drawn, the timings are up to 3 times slower.

The resulting images are (all features)

and for example (just icons)

[johsin18]

I have made the patch less intrusive. It does not touch any appliation code anymore, just test code. So it should be very safe to merge it in.

I found the working approach in AbstractMapRendererPerformanceTestParent, which raises the questions whether StyledMapRendererPerformanceTest has superseded MapRendererPerformanceTest (at least MapRendererPerformanceTest.testPerformanceDrawFeatures). Then, the later should maybe be removed instead of fixed.

@simon04 Could you have a look maybe?
Some commits just improve the measurement accuracy, you can leave them out if you don't like them.
​​https://github.com/johsin18/josm/commits/fix-MapRendererPerformanceTest

[simon04]

In 16542/josm:

fix #19225 - MapRendererPerformanceTest does not render as intended anymore (patch by johsin18, modified)

[simon04]

Thank you!

[simon04]

In 16822/josm:

see #19225 - MapRendererPerformanceTest: call DataSet.clearMappaintCache