[Patch] Updates for tests on units

[skyper]

Please, find attached patch file: josm_validator_numeric_unit_abb.patch​
which:

• adds test about long forms of common units and autofixes them to abbreviations: m, ft and t
• combines the test for separator and the general warning to one for each group instead of one for each tag
• adds maxaxleload and maxlength to the tests

I was wondering why the regex for width differs compared to the other tags but did not change it, so far:
Edit: I changed it.

*[width][width !~ /^(([0-9]+\.?[0-9]*( [a-z]+)?)|([0-9]+\'([0-9]+\.?[0-9]*\")?))$/]

instead of:

*[width][width !~ /^(([0-9]+\.?[0-9]*( (m|ft))?)|([0-9]+\'[0-9]+\.?[0-9]*\"))$/]

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-25 18:33:44 +0200 (Sat, 25 Apr 2020)
Revision:16382
Build-Date:2020-04-26 01:30:47
URL:https://josm.openstreetmap.de/svn/trunk

[skyper]

patch file

[skyper]

Oh, that was too fast:

• tons should probably not be abbreviated, for now, as we loose information. Probably, the territory needs to be checked to distinguish between the two different tonnes and tons.
• autofix does not proper work. Maybe combining the test was not a smart idea.
• check for separator for maxlength and maxaxleload is missing

[skyper]

version 2: no combinations of test, no "weight" so far

[skyper]

Ok, please find josm_validator_numeric_unit_abb_v2.patch​:

• harmonizes test for width to be in sync with other "length" tags
• adds maxaxleload and maxlength to the tests
• adds test about long forms of "length" units and autofixes them to abbreviations: m and ft

No tests for "weight" units, so far.

[skyper]

version 3, combine test without autofix

[simon04]

@Klumbumbus, could you review this patch, please?

[Klumbumbus]

Yes.

[Klumbumbus]

In 16685/josm:

fix #19163 - Adjust units validator tests: add autofixes for missing or multiple spaces and long forms of units, validate maxaxleload and maxlength too (patch by skyper, modified)

[Klumbumbus]

Please don't mix object types in asserts (node, way, relation) with different values to test. This makes it harder to read the asserts and for * selectors it makes no sense anyway.

[Klumbumbus]

(I unified the assert object types, added a few and adjusted the warning text.)