Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#19117 closed enhancement (fixed)

Ant: improve build

Reported by: simon04 Owned by: simon04
Priority: normal Milestone: 20.05
Component: Core Version:
Keywords: ant dependencies Cc: Don-vip

Description


Attachments (0)

Change History (22)

comment:1 by simon04, 5 years ago

In 16341/josm:

see #19117 - ant create-revision: detect SVN/Git based on dir

comment:2 by simon04, 5 years ago

In 16342/josm:

see #19117 - ant epsg-compile: depends on compile

comment:3 by simon04, 5 years ago

In 16345/josm:

see #19117 - ant epsg: skip if uptodate

comment:4 by simon04, 5 years ago

Vincent, in 2014 via r7040, you've changed the build to "do not create empty package-info.class files in javac task". Do you still know, why?

At the moment, repeatedly running ant compile recompiles all of the package-info.java files (output generated using <javac listfiles="yes" ...>):

compile-cots:
    [javac] Compiling 1 source file to /home/simon/src/josm.svngit/build
    [javac] /home/simon/src/josm.svngit/src/com/kitfox/svg/package-info.java

compile:
    [javac] Compiling 120 source files to /home/simon/src/josm.svngit/build
    [javac] /home/simon/src/josm.svngit/src/org/openstreetmap/josm/actions/audio/package-info.java
    [javac] /home/simon/src/josm.svngit/src/org/openstreetmap/josm/actions/corrector/package-info.java
    [javac] /home/simon/src/josm.svngit/src/org/openstreetmap/josm/actions/downloadtasks/package-info.java
    [javac] /home/simon/src/josm.svngit/src/org/openstreetmap/josm/actions/mapmode/package-info.java
    [javac] /home/simon/src/josm.svngit/src/org/openstreetmap/josm/actions/package-info.java
...

comment:5 by Don-vip, 5 years ago

I guess some tools choke with these empty class files (Jacoco or SonarQube maybe?)

comment:6 by simon04, 5 years ago

Maybe, we can exclude all package-info.java files from <javac>? We don't use annotation on the package level?

comment:7 by Don-vip, 5 years ago

I don't know if the class files are needed for the javadoc tool. That would be the only tool that could make use of these files.

comment:8 by simon04, 5 years ago

In 16346/josm:

see #19117 - ant compile: exclude package-info.java files, drop createMissingPackageInfoClass="false"

comment:9 by simon04, 5 years ago

In 16348/josm:

see #19117 - ant javadoc: add JOSM logo in doctitle

comment:10 by simon04, 5 years ago

In 16349/josm:

fix #19065, see #19117 - ant create-revision: write to resources/

comment:11 by simon04, 5 years ago

In 16350/josm:

see #19117 - ant: remove obsolete jmapviewer exclusions

comment:12 by Klumbumbus, 5 years ago

Netbeans doesn't like it:

ant -f C:\\Users\\stefa\\Documents\\OSM\\josm\\core\\ide\\netbeans\\nbbuild.xml -Dnb.internal.action.name=rebuild clean jar
Circular dependency: compile <- epsg-compile <- josmbase.epsg <- -post-compile <- compile
BUILD FAILED (total time: 0 seconds)

comment:13 by simon04, 5 years ago

In 16352/josm:

see #19117 - ant epsg-compile: cannot depend on compile (Netbeans)

comment:14 by simon04, 5 years ago

Resolution: fixed
Status: assignedclosed

comment:15 by GerdP, 5 years ago

I think r16349 is to blame. We need some changes in svn ignore, right?

C:\josm\core>svn st resources
?       resources\CONTRIBUTION
?       resources\LICENSE
?       resources\README
?       resources\REVISION

comment:16 by simon04, 5 years ago

In 16376/josm:

see #19117 - svn:ignore

comment:17 by simon04, 5 years ago

@GerdP, indeed. Thanks for the pointer. Done in r16376.

comment:18 by Klumbumbus, 5 years ago

Milestone: 20.0420.05

Milestone renamed

comment:19 by simon04, 5 years ago

In 16878/josm:

see #19117 - ant create-revision: do not depend on resolve

comment:20 by Stereo, 5 years ago

ant -DnoJavaFX=true test-unit-hardfail -Dtest.headless=true doesn't like it:

BUILD FAILED
/Users/runner/work/josm/josm/build.xml:384: Problem: failed to create task or type antlib:org.apache.ivy.ant:retrieve
Cause: The name is undefined.
Action: Check the spelling.
Action: Check that any custom tasks/types have been declared.
Action: Check that any <presetdef>/<macrodef> declarations have taken place.
No types or tasks have been defined in this namespace yet

comment:21 by simon04, 5 years ago

In 16891/josm:

see #19117 - ant test-unit-hardfail depends on resolve

comment:22 by simon04, 5 years ago

In 16898/josm:

see #19117 - +ant ivy-checkdepsupdate

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.