Typo in original string

[sanna]

../core/src/org/openstreetmap/josm/io/OsmServerWriter.java:161 "An error occoured: {0}"
occoured > occurred

Typo present in svn trunk as of 2008-12-28

PS. If this sounds familiar, the same word has been found to be misspelled on a different location (trunk/src/org/openstreetmap/josm/plugins/PluginException.java:18) previously... There it was corrected to 'occured' but I do believe the correct spelling is with two 'r'?

[sanna]

I searched for the spelling "occured" within launchpad/JOSM and found four instances, the one mentioned above in PluginException.java and also in :
../plugins/openstreetbugs/src/org/openstreetmap/josm/plugins/osb/api/EditAction.java:69
../plugins/openstreetbugs/src/org/openstreetmap/josm/plugins/osb/api/CloseAction.java:64
../plugins/openstreetbugs/src/org/openstreetmap/josm/plugins/osb/gui/action/NewIssueAction.java:122

The spelling "occurred" on the other hand occurs (sic!) in seven places:
../core/src/org/openstreetmap/josm/tools/BugReportExceptionHandler.java:64 & 93
../core/src/org/openstreetmap/josm/actions/SaveActionBase.java:162, 172, 203 & 213
../plugins/wmsplugin/src/wmsplugin/Grabber.java:53

Whichever spelling is the correct one, there should at least be consistency.

[stoecker]

Well, occurred is correct. :-) I'm fixing these.

BTW, When you do some review for english texts, then please go on and tell the errors. Claudius did this for German language and it surely improves the overall quality.

To save me work sending a diff file is best.

This includes:

• different wordings for identical meaning should be unified,
• Spelling error
• grammar
• ...

[sanna]

Replying to stoecker:

Well, occurred is correct. :-) I'm fixing these.

Thank you!

BTW, When you do some review for english texts, then please go on and tell the errors. Claudius did this for German language and it surely improves the overall quality.

I surely will go on reporting the errors I find.

To save me work sending a diff file is best.

Well, I know I should... Though I am translating JOSM entirely via the launchpad site, I do not even (currently) have a svn-checkout of JOSM, so creating a diff for the originals is a bit of a chore for me... I will look into the question, but please excuse me if I in the meantime continue to report the typos in the format I have so far used.

This includes:

• different wordings for identical meaning should be unified,
• Spelling error
• grammar
• ...

There is a wider problem that I so far have not had time to look into deeper; there are several strings that need to be translated twice, once with a full stop and once without. Several of these are surely quite valid depending on the various contexts in which the strings are used, but in some instances it seems to be more a style choice from the coders. However, this requires a look at the string set as a whole to determine where full sentences (with full stops etc.) should be used, and where fragments are the preferred option. Unfortunately I do not have the time for such right now. Maybe later... *smile*