Modify

Opened 5 years ago

Closed 5 years ago

#18945 closed enhancement (wontfix)

GettingStarted: display JOSM banner

Reported by: simon04 Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: banner logo Cc:

Description (last modified by simon04)

We could display source:trunk/nodist/images/logo/bannerhorizontal.jpg on JOSM's GettingStarted panel (i.e. initial screen of JOSM).


Attachments (1)

2020-03-16-233436_1918x1066_scrot.png (241.5 KB ) - added by simon04 5 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by simon04, 5 years ago

Description: modified (diff)
  • src/org/openstreetmap/josm/gui/GettingStarted.java

    diff --git a/src/org/openstreetmap/josm/gui/GettingStarted.java b/src/org/openstreetmap/josm/gui/GettingStarted.java
    index 6083ed746..8166caaa2 100644
    a b private void getMOTD() {  
    175175            if (!contentInitialized && Config.getPref().getBoolean("help.displaymotd", true)) {
    176176                try {
    177177                    content = new MotdContent().updateIfRequiredString();
     178                    content = content.replaceFirst("<h1",
     179                            "<center><img src='https://josm.openstreetmap.de/export/16155/josm/trunk/nodist/images/logo/bannerhorizontal.jpg'></center><h1");
    178180                    contentInitialized = true;
    179181                    ProxyPreference.removeProxyPreferenceListener(this);
    180182                } catch (IOException ex) {

comment:2 by Don-vip, 5 years ago

I don't find it fits nicely in the UI. And we lose a lot of vertical space. I can see a LOT of people going berserk with such a change, when I remember all the rude feedback I received for the Christmas easter egg. I don't think you want that for yourself :)

Last edited 5 years ago by Don-vip (previous) (diff)

comment:3 by skyper, 5 years ago

The logo is already present during startup. The banner will only fit on Hidpi displays.

comment:4 by stoecker, 5 years ago

Resolution: wontfix
Status: newclosed

And: If we'd do that it would go to StartupPage and not into code.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.