[Patch] Public transport stop position icons do not show PT type icon in lists

[Claudius]

What steps will reproduce the problem?

1. Select a node tagged with public_transport=stop_position and any of the modality tags, e.g. subway/light_rail/monorail/tram/train=yes e.g. ​https://www.openstreetmap.org/node/7035457392
2. Check the icon shown in the object selection, relation viewer and compare to how it is rendered in the map editor view

What is the expected result?

The modality specific icon to show everywhere in the UI.

What happens instead?

There is only a red dot shown instead of the subway/light_rail/monorail/train/... symbol

Please provide any additional information below. Attach a screenshot if possible.

This is a regression, within the last 2-3 weeks. I can't really narrow it down any further, but previously all lists and relation lists showed the correct icon and not just the red dot. In the attached screenshot everywhere you can see the red "stop position" dot there should be the train icon shown instead.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-03-16 00:07:51 +0100 (Mon, 16 Mar 2020)
Build-Date:2020-03-16 02:30:50
Revision:16149
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16149 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1909 (18363)
Memory Usage: 205 MB / 989 MB (74 MB allocated, but free)
Java version: 1.8.0_241-b07, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-Dsun.java2d.opengl=true]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.20)
+ OpeningHoursEditor (35250)
+ apache-commons (35362)
+ apache-http (35092)
+ buildings_tools (35364)
+ jna (35092)
+ pt_assistant (2.1.10-79-gb14a159)
+ tageditor (35258)
+ turnlanes-tagging (283)
+ utilsplugin2 (35366)
+ wikipedia (1.1.3)

Tagging presets:
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ https://raw.githubusercontent.com/yopaseopor/indoormap/master/indoormap-style.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/AdvertisingStyle&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Bench&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Building_Levels_Labels&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/RU-SubwayEntranceLabeling&zip=1
+ https://github.com/osmlab/appledata/archive/josm_paint_inline_validation.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
+ https://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1

Last errors/warnings:
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- E: java.lang.IllegalStateException: Failed to retrieve clipboard content

[skyper]

I can reproduce. There are two problems here:

• a missing preset for railway=stop
  • see #18942. The icon in the Tags/Memberships panel is correct and did not change.
• the icon in all other panels and windows.
  • Does not happen with tested (r15937), e.g. regression

[simon04]

Likely a regression of r16060: MapImage.imageResource might not be available yet.

[simon04]

@team, can someone please review this patch? Thanks!

[Don-vip]

Looks ok, let's give it a try.

[simon04]

In 16153/josm:

fix #18941 - MapImage.getImageResource: wait for image to load