Sidebuttons keep increasing after using walk mode

[GhostFoxSledgehammer]

What steps will reproduce the problem?

1. Use walk mode in mapillary.
2. Right click on Mapillary main dialog.

What is the expected result?

PopupMenu with Play,Pause and Stop buttons appear and changes back to default buttons.

What happens instead?

Buttons keep increasing after every time walk mode is used.

Please provide any additional information below. Attach a screenshot if possible.

I think this is due to mapillary image dialog being created every time Walk Mode is used

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-02-26 10:50:27 +0100 (Wed, 26 Feb 2020)
Build-Date:2020-02-26 09:52:41
Revision:15937
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15937 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1903 (18362)
Memory Usage: 373 MB / 989 MB (130 MB allocated, but free)
Java version: 1.8.0_241-b07, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080

Plugins:
+ Mapillary (1.5.20-31-g6a694d9-dirty)
+ apache-commons (35092)
+ apache-http (35092)
+ javafx-windows
+ jna (35092)
+ log4j (35092)
+ routing (35313)
+ wikipedia (1.1.3)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Last errors/warnings:
- W: Unable to request certificate of https://grca.nat.gov.tw
- W: Plugin javafx-windows requires Java version 10. The current Java version is 8. You have to update Java in order to use this plugin.
- E: unable to find dependency javafx for plugin Mapillary
- W: Region [userProfile_BLOCK_v2]  Problem verifying disk.
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: java.net.SocketException: Unexpected end of file from server. Cause: java.net.SocketException: Unexpected end of file from server
- W: org.openstreetmap.josm.tools.bugreport.BugReportSender$BugReportSenderException: java.net.SocketException: Unexpected end of file from server. Cause: java.net.SocketException: Unexpected end of file from server. Cause: java.net.SocketException: Unexpected end of file from server

[taylor.smock]

It looks like it is because there is not currently a method to clear buttonActions before adding the new buttons.

[taylor.smock]

Minimal patch, more likely to break plugins relying upon existing functionality

[taylor.smock]

Add method to clear button actions. Requires plugin support.

[taylor.smock]

I've attached two patches, one assumes that everyone wants to clear the buttonActions when createLayout is called. The other requires the plugin to specifically call clearButtonActions() prior to creating the new layout.

[Don-vip]

I'll apply the second one to avoid unexpected weird regressions in existing plugins.

[Don-vip]

In 16113/josm:

see #18912 - add new method to clear button actions

[taylor.smock]

I've got a patch that fixes this issue. It might be a little while before it makes it to a release version though, but I'm going to go ahead and close this bug.

(until I rebase again, url for patch is ​https://gitlab.com/gokaart/josm-mapillary-plugin/-/commit/5156b48f03400e7d9732f0d8aef5263b94c94441 ).