Opened 5 years ago
Closed 5 years ago
#18886 closed enhancement (fixed)
OsmReader: refactor/simplify/improve
| Reported by: | simon04 | Owned by: | simon04 |
|---|---|---|---|
| Priority: | normal | Milestone: | 20.03 |
| Component: | Core | Version: | |
| Keywords: | yourkit performance | Cc: |
Description
Attachments (0)
Change History (8)
comment:1 by , 5 years ago
comment:3 by , 5 years ago
In 16080/josm:
2016ms were spent in parseTimestamp out of 17735ms spent in parseNode. This change reduces the time to 955ms.
comment:4 by , 5 years ago
| Owner: | set to |
|---|---|
| Status: | assigned → new |
comment:5 by , 5 years ago
While you're looking at JOSM performance, do you understand why the JOSM performance tests no longer work?
https://josm.openstreetmap.de/jenkins/job/JOSM-Performance/
They are broken for several months/years but I failed to understand why.
EDIT: the last successful build was with r13170: https://josm.openstreetmap.de/jenkins/job/JOSM-Performance/175/
EDIT2: I found again my call for help: https://josm.openstreetmap.de/ticket/15310#comment:43
comment:6 by , 5 years ago
Replying to simon04:
In 16077/josm:
Verified: reversing https://www.openstreetmap.org/way/246449783 still shows dialog for direction-dependent railway signals.
comment:7 by , 5 years ago
| Status: | new → assigned |
|---|
comment:8 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
First finding: parsing https://download.geofabrik.de/europe/montenegro-latest.osm.bz2 spends 15s in
org.openstreetmap.josm.data.osm.Node#updateDirectionFlags(nodes only) out of a total 149s fororg.openstreetmap.josm.io.OsmReader#parse