When using a preset, combo with editable="false" parameter is twice less height from usual

[KorneySan]

What steps will reproduce the problem?

1. Make a preset using any <combo> control
2. Set editable="false"
3. Open any element with preset
4. See the shrinked combo

What is the expected result?

Combo should not change its size.

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-02-01 01:10:57 +0100 (Sat, 01 Feb 2020)
Build-Date:2020-02-01 00:12:46
Revision:15806
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15806 ru) Windows 7 64-Bit
OS Build number: Windows 7 Ultimate (7601)
Memory Usage: 936 MB / 1820 MB (565 MB allocated, but free)
Java version: 1.8.0_231-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1680x1050
Maximum Screen Size: 1680x1050
Dataset consistency test: No problems found

Plugins:
+ CustomizePublicTransportStop (35248)
+ ShapeTools (1240)
+ buildings_tools (35248)
+ imagery_offset_db (35248)
+ intersection (0.0.7)
+ pt_assistant (34678)
+ public_transport (35313)
+ tageditor (35258)
+ turnlanes-tagging (283)
+ turnrestrictions (35313)

Tagging presets:
+ f:\Downloads\Программы\JOSM\Presets_PublicTransport_Gomel_BY.zip

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

[KorneySan]

Three combos in the middle have editable="false", two others not.

[Klumbumbus]

Closed as duplicate of #6157.

[KorneySan]

5 years old bug and no solution yet?..

[Klumbumbus]

Yes. It is not high priority. Remember your bug report is the 18714th one. There is a lot to do.

[KorneySan]

Replying to Klumbumbus:

Yes. It is not high priority. Remember your bug report is the 18714th one. There is a lot to do.

Can I see the code of that part?

[Klumbumbus]

Much likely at https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Combo.java
If you want to create a patch, please attach it to the other ticket #6157.

[Don-vip]

In 18221/josm:

fix #21319 - Refactoring of class hierarchy around JosmComboBox / AutoCompComboBox (patch by marcello):

• Code reuse: JosmComboBox now uses a JosmTextField as editor
• Code reuse: AutoCompComboBox now uses AutoCompTextField as editor
• JosmComboBox uses more of the original L&F
• JosmComboBox lists now expand all the way to the bottom or the top of the screen
• Variable height items in combobox lists now work, see #19321
• Autocomplete uses different algorithm, fix #21290
• editable="false" comboboxes in Presets now work, fix #6157 see #11024 see #18714
• The user may toggle LTR-RTL script in JosmTextField (menu and ctrl+space)
• LTR-RTL automatically toggles according to key in AddTag and EditTag dialogs, fix #16163