[patch] Add support for natural=shrub in presets

[sowa1980]

Добавьте пожалуйста в JOSM возможность отмечать:

1. Линейно кустарник
2. Точечно кустарник

Аналогично, как и с деревьями.
В данный момент , если попытаться внести эти объекты так то JOSM ругается и говорит что это ошибка.

[simon04]

Translation:

Please add in JOSM the ability to mark:

1. Linearly shrub
2. Dotted shrub

Similarly, as with trees.
At the moment, if you try to contribute these objects, then JOSM swears and says that this is a mistake.

[GerdP]

Is it about adding the tag natural=shrub to the presets?

[Klumbumbus]

Replying to GerdP:

Is it about adding the tag natural=shrub to the presets?

I rather think the support of natural=scrub on unclosed ways and nodes.

[GerdP]

I found natural=shrub only in ignoretags.cfg so I assume that there is an external file with rules which complains about this tag. JOSM doesn't render it nor does it complain when it is used on a node or unclosed way.

[Don-vip]

Thanks for your report, however your ticket is incomplete and therefore not helpful in its current form.

Please add all needed information according to this list:

• The required parts of the Status Report from your JOSM.
  • Please, use Report Bug from Help menu and copy & paste.
• Describe what behaviour you expected.
• Describe what did happen instead.
• Describe if and how the issue is reproducible.
• Add any relevant information like error messages or screenshots.

To ensure that all technical relevant information is contained, create new tickets by clicking in JOSMs Main Menu on Help → Report Bug.

Remember: This is a generic notice so we don't need to write the same stuff again and again. It may only apply in parts to the specific case!

[Klumbumbus]

Replying to GerdP:

I assume that there is an external file with rules which complains about this tag.

No it is an internal rule "...shrub looks like scrub..." r14739 :)

shrub may be worth adding to the internal presets, especially as we "forbid" the usage of shrub scrub on nodes. Related: #15117

[GerdP]

Replying to Klumbumbus:

shrub may be worth adding to the internal presets, especially as we "forbid" the usage of shrub on nodes. Related: #15117

I guess you meant "usage of scrub on nodes"?

natural=shrub doesn't produce a warning for me when used on a node
natural=scrub produces a warning when used on a node
natural=shrub produces a warning when used on an unclosed way: "Unclosed way - natural type shrub"

There are several warnings for natural=scrub when not used on a closed way.

[Klumbumbus]

Replying to GerdP:

I guess you meant "usage of scrub on nodes"?

Yes, sorry for the confusion.

[sowa1980]

Хотелось бы иметь возможность вносить точечно и линейно данные объекты это первое, второе нет заготовок в джосме в тегах, третье это ошибки о которых я писал выше что JOSM ругается, если вносить так. кустарник не всегда занимает гектары или значительные площади особенно если это газоны, где нужна линия или точечный объект.
---
Deepl translation:
I would like to be able to make dotted and linearly these objects is the first, the second there are no blanks in the josm in the tags, the third is the errors about which I wrote above that JOSM swears if you make this. shrubs do not always occupy hectares or significant areas, especially if it's lawns where you need a line or dotted object.

[Don-vip]

@GerdP @Klumbumbus if this ticket is clear enough for you, can you please update its title/description?

[skyper]

nice icon, sadly does not work in mappaint; Own work, derived from non-commercial free to use.

[skyper]

preset patch

[skyper]

map style patch

[skyper]

I created an nice icon, , but it does not render in mappaint.

Once again, the preset and style coding is easy, see josm_18685_shrub_defaultpreset.xml.patch​ and josm_18685_shrub_elemstyles.mapcss.patch​, but finding nice looking icons is the challenge. Does anybody have a link or hint.

[skyper]

What I minute, I need to add the path to the icon if I want to get it rendered.

Works if the icon is placed under rescource/images/presets/landmark/.

[Klumbumbus]

Replying to skyper:

What I minute, I need to add the path to the icon if I want to get it rendered.

Or you add the path where you store your icons for testing in the preferences at the lower part of the Map Paint Styles register at "Icons paths:"

[skyper]

Replying to Klumbumbus:

Replying to skyper:

What I minute, I need to add the path to the icon if I want to get it rendered.

Or you add the path where you store your icons for testing in the preferences at the lower part of the Map Paint Styles register at "Icons paths:"

Yes, thanks, I know. Still, have to take that the paths there are correct and that no icons with identical name exist. Was just an user fault.

Talking about this ticket, in map paint style, I need a different placement and rotation for the icon, as it needs to be placed towards the to way in the case of no_entry.
Edit: Sorry, wrong ticket (#20833).
This ticket should be done with the two patches and the icon.

[skyper]

Ping

@team:
May I, please, get some feedback, thanks.
Additionally, it gets complicated if too many patches are waiting for integration as defaultpresets.xml is one file and the number of conflict will possibly get higher with more patches.

[Klumbumbus]

The icon contains the license ​http://creativecommons.org/licenses/by-nc-sa/4.0/. We can't use this in JOSM as JOSM might be used for commercial purpose.

[skyper]

Replying to Klumbumbus:

The icon contains the license ​http://creativecommons.org/licenses/by-nc-sa/4.0/. We can't use this in JOSM as JOSM might be used for commercial purpose.

Is it about using the software or about distributing the software?
Well, I created it myself and can add another license but I wonder if that is true. Thought it is about the reuse of the icon in another work and that BY-NC-SA 4.0 without author is working as the icon is not compiled in but I am far from being an expert on legal issues.

[Klumbumbus]

Replying to skyper:

Well, I created it myself and can add another license

You wrote "derived from non-commercial free to use". When it is derived from "nc" you cannot apply a less stricter license on your derived work. What is the original source?

I am far from being an expert on legal issues.

Me too, thats why I would like to go "on the safer side" and use CC0 / PD for new icons.

[skyper]

original icon source

[skyper]

Replying to Klumbumbus:

Replying to skyper:

Well, I created it myself and can add another license

You wrote "derived from non-commercial free to use". When it is derived from "nc" you cannot apply a less stricter license on your derived work. What is the original source?

Damm yes, you are right.
I've attached the original source​.

I am far from being an expert on legal issues.

Me too, thats why I would like to go "on the safer side" and use CC0 / PD for new icons.

There should be some stricter licenses available for icons, if not I am done with creating icons. Can we clarify this?

[Klumbumbus]

In 17930/josm:

fix #18685 - Add natural=shrub (patch by skyper, icon from ​https://openclipart.org/detail/258072/bush, resized, PD and CC0 licensed)