Selection toggle dialog: Harmonize display of icons for "fixme" and "note"

[skyper]

What steps will reproduce the problem?

1. Have six nodes, three with FIXME=* and three with note=*. First node of each group has no additional tag, the second node of each group has additionally an tag without icon like amenity=social_facility and the last node of each group has a tag with icon like amenity=atm. See attached file​.
2. Select all nodes
3. Have a look at the icons in Selection toggle dialog

What is the expected result?

Somehow more harmonized icons like a big "N" or "F" for objects without any additional tag or tags without icons. Use only one color instead of black and red.

What happens instead?

A complete mixture:

• No big "F" for only FIXME=* present
• Really tiny, red "F" or "N" for tags without icons present

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-02-02 18:47:18 +0100 (Sun, 02 Feb 2020)
Revision:15810
Build-Date:2020-02-03 02:30:51
URL:https://josm.openstreetmap.de/svn/trunk

[skyper]

selection list screenshot

[skyper]

mapview screenshot

[skyper]

example file

[Klumbumbus]

for fixme use fixme not FIXME as key. That fixes the missing big F as there is no preset for FIXME just for fixme. Related: #17809

[stoecker]

Align description and example.

[skyper]

Replying to Klumbumbus:

for fixme use fixme not FIXME as key. That fixes the missing big F as there is no preset for FIXME just for fixme. Related: #17809

Nice spot, gonna upload a preset for FIXME. Noticed it, prior only in TagsMembership toggle dialog.

Anyway, using the small F is not a solution. Either show no icon (general object icon) or take care that the icon has the appropriate size.

[skyper]

Replying to skyper:

Nice spot, gonna upload a preset for FIXME.

See Presets/FIXME

[Klumbumbus]

I'm against wiki:Presets/FIXME as it supports the FIXME=* tag. The goal should be to get rid of it and use fixme=* only.

[skyper]

Replying to Klumbumbus:

I'm against wiki:Presets/FIXME as it supports the FIXME=* tag.

I can delete it from the JOSM page.

The goal should be to get rid of it and use fixme=* only.

Who says that? There was no global decision and the discussions never came to a conclusion. The ​wiki page mentions both usages.

iD does silently change it but I am against it. And if you look at the numbers of usage FIXME still rest at around 11% and is usually added by manual edits while fixme is often used in imports.

[stoecker]

Replying to skyper:

The goal should be to get rid of it and use fixme=* only.

Who says that? There was no global decision and the discussions never came to a conclusion. The ​wiki page mentions both usages.

iD does silently change it but I am against it. And if you look at the numbers of usage FIXME still rest at around 11% and is usually added by manual edits while fixme is often used in imports.

JOSM does not always follow "global decision and the discussions". We simply do something (like replacing 3 variants of boolean with the yes/no standard we have now). Promoting different spelling for something is not a good idea. That makes automatic interpretation very hard.

[skyper]

Replying to stoecker:

JOSM does not always follow "global decision and the discussions". We simply do something (like replacing 3 variants of boolean with the yes/no standard we have now).

That is a different story but is needed for #18929.

Promoting different spelling for something is not a good idea. That makes automatic interpretation very hard.

In general I go with you but I see it for some special keys and FIXME is special in my eyes. Plus JOSM supports it (almost) completely since I use it and in fact is missing in #12135.

Well, if you are still against it, on a JOSM page, I can move it or silently only use it locally.

[Klumbumbus]

Replying to skyper:

only use it locally.

Yes, please. Supporting the use of a duplicate tag is worse than a missing icon in the selection list.

[skyper]

I changed the page and removed the code. If you prefer to delete the page go ahead.

Replying to Klumbumbus:

Yes, please. Supporting the use of a duplicate tag is worse than a missing icon in the selection list.

The preset link in the Tags/Membership panel is missing, too.

[Klumbumbus]

Replying to skyper:

If you prefer to delete the page go ahead.

Someone else did alredy before my comment:10.