#18572 closed enhancement (fixed)
Bicycle routes wrong warning
Reported by: | Dardy | Owned by: | Klumbumbus |
---|---|---|---|
Priority: | normal | Milestone: | 20.01 |
Component: | Core validator | Version: | |
Keywords: | Cc: |
Description
Josm validator shows a warning message when a relation route=bicycle type=route contains some points related to guideposts.
Warning message is: type 'node' of relation member with role " does not match accepted types 'way/closed way' in preset bicycle route. In route wiky (https://wiki.openstreetmap.org/wiki/Relation:route) seems that points are accepted for guidepost.
Same route with same guidepost points, but with route=hiking instead bicycle does not show any warning.
Guideposts exist for hiking but also for bike
Attachments (2)
Change History (13)
by , 5 years ago
Attachment: | warning.PNG added |
---|
comment:1 by , 5 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Type: | defect → enhancement |
Version: | tested |
comment:2 by , 5 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:3 by , 5 years ago
Milestone: | 20.02 → 20.01 |
---|
follow-up: 6 comment:5 by , 5 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Checked the solution with josm latest version but seems not complete. Accordingly to wiky guidepost role should not be mandatory, so there are the following cases possible:
- relation with points and guidepost role set -> OK (fixed)
- relation with points without guidepost role -> WARNING (to be fixed, no warning expected, as role is not mandatory)
- relation with points with other role -> WARNING (it's correct)
comment:6 by , 5 years ago
Replying to Dardy:
Checked the solution with josm latest version but seems not complete. Accordingly to wiki guidepost role should not be mandatory,
Could you, please, point me to the wiki page where you get the information about guidepost from? On the main route wiki page (route relation) the role "guidepost" is demanded.
follow-ups: 8 9 comment:7 by , 5 years ago
I see in the table "Members" at Role=guidepost a "?" (=optional) and a "0+" (Optional; 0 or more instances). Where did you see any "demanded"?
comment:8 by , 5 years ago
Replying to mdk:
I see in the table "Members" at Role=guidepost a "?" (=optional) and a "0+" (Optional; 0 or more instances). Where did you see any "demanded"?
I read it differently:
- node with empty role is not allowed
- at least one way without role is needed
- all other members with role are optional but the role is demanded. See "stop" for example.
comment:9 by , 5 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
If a guidepost is added to the relation then it must get the role "guidepost" and not stay with an empty role.
by , 5 years ago
Attachment: | tagInfo roles.PNG added |
---|
comment:10 by , 5 years ago
I also read like mdk, nodes do not require mandatory role. A node in a route can be only a guidepost, so the role should be allowed even if a redundant information.
Also TagInfo (image attached) show that a blank role is a standard de facto (318k nodes with blank role vs 61k nodes with filled role) even if the wiki page is so confusing :)
comment:11 by , 5 years ago
The "! 1+" and "? 0+" in the column "Recurrence" of the table osmwiki:Relation:route#Members clearly refer to the number of objects with the role written in the column "role". (See also osmwiki:Template:Rolerecurrence)
In 15715/josm: