upload dialog: preserve existing values when obtaining source values from layers

[skyper]

From #18522
skyper 18522#comment:3:

Additionally:

• Existing values are always overridden instead of only adding new ones to the existing ones.

taylor.smock 18522#comment:4:

...
I didn't consider the former since obtain from current layers replaced the source changeset tag. I can see how that might be annoying though.

What steps will reproduce the problem?

1. Have an imagery layer and a data layer with changes
2. Upload data
3. In upload dialog add a source tag to changeset
4. Then click on "just once" to automatically obtain source from active layers

What is the expected result?

additional sources are added to the string

What happens instead?

previous value is overridden

Please provide any additional information below. Attach a screenshot if possible.

Think this should be similar to the plugin support for source tags.
Properly have to check existing tags for no duplication.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-01-05 23:29:48 +0100 (Sun, 05 Jan 2020)
Revision:15644
Build-Date:2020-01-06 02:30:57
URL:https://josm.openstreetmap.de/svn/trunk

[Don-vip]

I think the current behaviour is ok. If you want to customize the source tag, just do it the other way, click first on just once then type whatever you want.

[taylor.smock]

Would you want past "manual" sources kept if the checkbox for Automatically obtain source from current layers is checked? To me, that would defeat the purpose of having JOSM automatically obtain source from current layers.

I could try to do something where I detect common manual entries (e.g., survey) or loop through every layer and ignore those entries. But then if a plugin adds a source programmatically (e.g., if object added (MapWithAI) or if image opened (OpenStreetCam/Mapillary), then return source tag), then it can be problematic (especially for the latter -- the former just checks the undo/redo stack for specific commands and that the added object(s) still exist).

Alternatively, I could store the automatically generated source values somewhere, and just replace that, but then that could cause issues where they have a layer from their local government (e.g., an address database set), where they have permissions to use it, they have imports set up, but it doesn't auto-populate the "Source" field with a reasonable source (maybe "​http://localhost:80/imagery" becomes "Locality Address DataSet").

In short, while it is somewhat annoying to add specific sources that are not standard layers, I think that it is probably as good as it is going to get for general use.

I, personally, am not inclined to change it, especially since most of my data comes from geotagged images, when it isn't from a background layer.

Honestly, it would be a better idea to make certain that any possible source has a layer in JOSM that can be queried for a source tag.

[skyper]

You are right. Need to adjust my workflow. It some how interferes with the list of recent used values (history) on the right side of the text box but could be even wanted.

[skyper]

Ticket #13598 has been marked as a duplicate of this ticket.