Modify

Opened 5 years ago

Closed 5 years ago

#18387 closed defect (fixed)

Combine way action refuses to combine new way with oneway

Reported by: GerdP Owned by: team
Priority: major Milestone: 19.12
Component: Core Version:
Keywords: template_report, regression Cc:

Description

What steps will reproduce the problem?

  1. Load attached sample
  2. Select new way
  3. Select oneway
  4. Press C (Combine ways)

What is the expected result?

Popup that asks if ways should be reversed

What happens instead?

popup "Could not combine ways"

Please provide any additional information below. Attach a screenshot if possible.

If you select the two ways in the opposed order it works fine.
Regression of r15554 (method isConnected() returns false which is wrong).

Build-Date:2019-12-04 10:43:48
Revision:15557
Is-Local-Build:true

Identification: JOSM/1.5 (15557 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1903 (18362)
Memory Usage: 845 MB / 1753 MB (425 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:59404, -ea, -Dfile.encoding=UTF-8]
Program arguments: [--debug]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35242)
+ apache-commons (35092)
+ buildings_tools (35171)
+ continuosDownload (82)
+ ejml (35122)
+ geotools (35169)
+ jaxb (35014)
+ jts (35122)
+ merge-overlap (35072)
+ o5m (34908)
+ opendata (35179)
+ pbf (35033)
+ poly (34991)
+ reverter (35226)
+ undelete (34977)
+ utilsplugin2 (35238)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

Attachments (1)

regress.osm (2.7 KB ) - added by GerdP 5 years ago.

Download all attachments as: .zip

Change History (2)

by GerdP, 5 years ago

Attachment: regress.osm added

comment:1 by GerdP, 5 years ago

Resolution: fixed
Status: newclosed

In 15558/josm:

fix #18387 Combine way action refuses to combine new way with oneway (regression from r15554)
I somehow expected that NodeGraph.getOutboundPairs(Node node) would return predessors and successors.
Maybe that routine should be renamed to getSuccessorPairs?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.