Changes between Initial Version and Version 1 of Ticket #18381, comment 5


Ignore:
Timestamp:
2019-12-11T19:29:18+01:00 (5 years ago)
Author:
taylor.smock

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #18381, comment 5

    initial v1  
    11JOSM core:
    2 `src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetNameTemplateList.java`: implements TaggingPresetListener already
    3 `src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSelector.java`: 18381.2.patch (''only constructed once, and then stored'')
    4 `src/org/openstreetmap/josm/gui/tagging/presets/items/PresetLink.java`: It looks like a transient check to me (i.e., does a preset currently exist?)
    5 `src/org/openstreetmap/josm/data/osm/search/SearchCompiler.java`: I don't think this needs anything
    6 `src/org/openstreetmap/josm/data/validation/tests/RelationChecker.java`: 18381.2.patch
    7 `src/org/openstreetmap/josm/data/validation/tests/TagChecker.java`: 18381.1.patch
     2~~`src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetNameTemplateList.java`~~: implements TaggingPresetListener already
     3~~`src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSelector.java`~~: 18381.2.patch (''only constructed once, and then stored'')
     4~~`src/org/openstreetmap/josm/gui/tagging/presets/items/PresetLink.java`~~: It looks like a transient check to me (i.e., does a preset currently exist?)
     5~~`src/org/openstreetmap/josm/data/osm/search/SearchCompiler.java`~~: I don't think this needs anything
     6~~`src/org/openstreetmap/josm/data/validation/tests/RelationChecker.java`~~: 18381.2.patch
     7~~`src/org/openstreetmap/josm/data/validation/tests/TagChecker.java`~~: 18381.1.patch
    88
    99
    1010Plugins:
    1111`surveyor/src/org/openstreetmap/josm/plugins/surveyor/action/TaggingPresetAction.java`: Doesn't look like an issue (not cached)
    12 `tageditor/src/org/openstreetmap/josm/plugins/tageditor/preset/ui/TabularPresetSelector.java`: Needs work
     12~~`tageditor/src/org/openstreetmap/josm/plugins/tageditor/preset/ui/TabularPresetSelector.java`~~: Needs work
    1313
    1414I made the incorrect assumption that anything that needed to listen to changes to TaggingPresets already implemented a listener.