[PATCH] Don't require a restart when a Tagging Preset is added/removed

[taylor.smock]

It would be nice to not have to restart after adding a preset.

[taylor.smock]

Add logic to destroy the preset menu and to rebuild it when the preset sources change

[Don-vip]

In 15582/josm:

fix #18381 - Don't require a restart when a Tagging Preset is added/removed (patch by taylor.smock)

[GerdP]

This does not work with TagChecker as it builds internal data structures based on the TaggingPresets, but only when method initialize()is called.

[taylor.smock]

Implement TaggingPresetListener in TagChecker and register itself as a listener with TaggingPresets

[GerdP]

@taylor.smock: Did you check all the other sources which use e.g. TaggingPresets.getTaggingPresets()?
Sorry, I should have asked this before...

[taylor.smock]

JOSM core:
src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetNameTemplateList.java: implements TaggingPresetListener already
src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetSelector.java: 18381.2.patch (only constructed once, and then stored)
src/org/openstreetmap/josm/gui/tagging/presets/items/PresetLink.java: It looks like a transient check to me (i.e., does a preset currently exist?)
src/org/openstreetmap/josm/data/osm/search/SearchCompiler.java: I don't think this needs anything
src/org/openstreetmap/josm/data/validation/tests/RelationChecker.java: 18381.2.patch
src/org/openstreetmap/josm/data/validation/tests/TagChecker.java: 18381.1.patch

Plugins:
surveyor/src/org/openstreetmap/josm/plugins/surveyor/action/TaggingPresetAction.java: Doesn't look like an issue (not cached)
tageditor/src/org/openstreetmap/josm/plugins/tageditor/preset/ui/TabularPresetSelector.java: Needs work

I made the incorrect assumption that anything that needed to listen to changes to TaggingPresets already implemented a listener.

[taylor.smock]

Modify JOSM classes to implement a TaggingPresetListener, where appropriate

[taylor.smock]

Clear lists where appropriate

[taylor.smock]

Patch for tageditor

[taylor.smock]

Replying to GerdP:

@taylor.smock: Did you check all the other sources which use e.g. TaggingPresets.getTaggingPresets()?
Sorry, I should have asked this before...

I think I got everything that is in the JOSM repository.

[GerdP]

I agree reg. core, not sure about plugin surveyor. It seems to store a preset in field preset?

[GerdP]

In 15583/josm:

see #18381: implement TaggingPresetListener to react on changes in tagging presets
regression from r15582

[taylor.smock]

It does store the preset in a field, but it seemed to me that it was more of an initialization check. If I were to modify that class, I'd probably just check if the reset still exists.

That being said, does anyone still use the plugin? I installed it and then went to GPS -> surveyor, and it promptly crashed on me when I tried to use it (see #18412). I fixed that issue, but another one popped up.

[GerdP]

I've never used surveyor, but it appears in some recent error reports, so it is installed by some users. Whatever that means.

[Don-vip]

is this ticket fixed?

[taylor.smock]

I believe it is fixed for core.

I need to make some changes to the surveyor plugin (as in, actually get it working), and then check and see if it needs to have a TaggingPresetListener. I'll file a separate bug for that, since it seems like it is going be more work.

I should probably make a separate bug for tageditor (see 18381.tageditor.patch, which I don't think has been applied yet).

[GerdP]

Ah, sorry, forgot about 18381.tageditor.patch. I think in destroy() a super.destroy() is missing?

[GerdP]

No, got it wrong. 18381.tageditor.patch applied with [o35258:35259]

[Don-vip]

In 15958/josm:

fix #18806 - see #18381 - fix tagging presets menu initialization (patch by taylor.smock)