add shop=fishing to presets

[mkoniecz]

What steps will reproduce the problem?

1. tag shop=fishing node

What is the expected result?

it has an icon

What happens instead?

it has no icon

Please provide any additional information below. Attach a screenshot if possible.

​https://wiki.openstreetmap.org/wiki/Tag:shop%3Dfishing

over 1k uses

See https://josm.openstreetmap.de/ticket/18310 for more background

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-11-17 21:16:26 +0100 (Sun, 17 Nov 2019)
Revision:15528
Build-Date:2019-11-18 02:30:59
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (15528 en) Linux Ubuntu 16.04.6 LTS
Memory Usage: 317 MB / 978 MB (146 MB allocated, but free)
Java version: 11.0.5+10-post-Ubuntu-2ubuntu116.04, Ubuntu, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-11-jre:amd64-11.0.5+10-2ubuntu1~16.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-6
libcommons-logging-java: libcommons-logging-java:all-1.2-1+build1
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (34977)
+ PicLayer (35104)
+ apache-commons (35092)
+ buildings_tools (35171)
+ continuosDownload (82)
+ ejml (35122)
+ geotools (35169)
+ imagery_offset_db (34908)
+ jts (35122)
+ log4j (34908)
+ measurement (35221)
+ reverter (35226)
+ todo (30306)

Validator rules:
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/deprecated.mapcss
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/unnecessary.mapcss
- ${HOME}/Documents/install_moje/OSM software/josm/data/validator/combinations.mapcss

Last errors/warnings:
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: javax.net.ssl.SSLException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out

[mkoniecz]

It seems that fitting both fish and hook is going to fail.

Based on ​https://upload.wikimedia.org/wikipedia/commons/thumb/6/63/Map_icons_by_Scott_de_Jonge_-_ice-fishing.svg/16px-Map_icons_by_Scott_de_Jonge_-_ice-fishing.svg.png from ​https://commons.wikimedia.org/wiki/File:Map_icons_by_Scott_de_Jonge_-_ice-fishing.svg and other attempts from ​https://commons.wikimedia.org/wiki/Category:Fishing_icons

Fish alone is not going to be clear, maybe fishing hook is a viable symbol? Seems not looking at symbols from ​https://commons.wikimedia.org/wiki/Category:Fishing_hooks_in_heraldry

[Klumbumbus]

Replying to mkoniecz:

It seems that fitting both fish and hook is going to fail.

Based on ​https://upload.wikimedia.org/wikipedia/commons/thumb/6/63/Map_icons_by_Scott_de_Jonge_-_ice-fishing.svg/16px-Map_icons_by_Scott_de_Jonge_-_ice-fishing.svg.png

I think with some pixel alignment this could work at 16px. However the license topic should be clearified first.

[Klumbumbus]

In 17069/josm:

fix #18336 - Add shop=fishing (icon from ​https://publicdomainvectors.org/en/free-clipart/US-National-Park-Maps-pictogram-for-an-angling-area-vector-image/15743.html, modified, PD and CC0 licensed)

[Klumbumbus]

In 17073/josm:

see #18336 - fix shop=fishing icon ViewBox