Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18153 closed enhancement (fixed)

location=roof or location=rooftop?

Reported by: Don-vip Owned by: Don-vip
Priority: normal Milestone: 19.09
Component: Internal preset Version:
Keywords: location roof rooftop power Cc: Klumbumbus, francois.lacombe

Description (last modified by Don-vip)

location=roof is now a popular tag.

osmwiki:Key:location states:

  • location=roof Used where a feature is located on the roof of a building.
  • location=rooftop possible synonym for roof (makes it clear it is on top of the roof). Only ~30% usage compared to roof.

We currently propose only location=rooftop but roof is used a lot more:


Should we propose only roof? both? It is used essentially with power generator features.

Attachments (1)

roof.PNG (47.1 KB ) - added by Don-vip 5 years ago.

Download all attachments as: .zip

Change History (12)

by Don-vip, 5 years ago

Attachment: roof.PNG added

comment:1 by Don-vip, 5 years ago

Description: modified (diff)

comment:2 by Don-vip, 5 years ago

Description: modified (diff)

comment:3 by francois.lacombe, 5 years ago

Power=generator usage may come from the recent project in UK to map every single solar panel (which is a great thing)

I'd be in favor of location=roof (if you are on the roof you may be often on the top of the building)

comment:4 by Don-vip, 5 years ago

Component: CoreInternal preset

comment:6 by SK53, 5 years ago

Don-vip I asked me to comment.

The rapid increase of location=roof does indeed come from the OSM-UK's quarterly project, but a little history is in order.

Originally my first solar panels were mapped with generator:location for which iD provides a preset tag of roof. After discussion we decided that this key was redundant with location and therefore changed to location=roof. Only after a while did I notice that this key's standard preset for the same thing was rooftop. Therefore AFAIK we inadvertently introduced synonymy in the tag values, but in part this was because of synonymy in keys.

I would suggest that generator:location as a tag be deprecated in favour of location. I cannot see any gain in namespacing the tag, and the namespaces become tedious when changing a solar farm polygon from power=generator to power=plant.

I have also noticed that for both location=surface and location=ground are offered as presets by different editors (iD & Vespucci). I have probably used both for solar panels mounted directly in the ground. I think the latter is preferable (surface would also be valid if the surface was a building roof, so it has some inherent ambiguity).

I suspect that at least one other tag in use with solar panels may be alternatively represented with a more widely used tag (generator:orientation and direction), but total number of instances is much smaller in that case.

Thanks for the detailed attention shown here.

comment:7 by Don-vip, 5 years ago

Milestone: 19.09
Owner: changed from team to Don-vip
Status: newassigned

comment:8 by Don-vip, 5 years ago

Resolution: fixed
Status: assignedclosed

In 15372/josm:

  • fix #18153 - prefer location=roof over location=rooftop, location over generator:location
  • update TLD from IANA
  • ignore cycling network tags icn[_ref], ncn[_ref], rcn[_ref], lcn[_ref]

comment:9 by Don-vip, 5 years ago

Thanks for the comments!

comment:10 by Don-vip, 5 years ago

In 15373/josm:

see #18153 - fix mapcss selector

comment:11 by francois.lacombe, 5 years ago

Thanks SK53 for the comprehensive comments

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.