Opened 5 years ago
Last modified 5 years ago
#18133 new enhancement
[Patch draft] Undo edit to selected object(s)
Reported by: | hjart | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core | Version: | |
Keywords: | undo | Cc: | skyper |
Description
Sometimes during my editing sessions I realize that I made a mistake earlier in the session. To undo that edit though, means that I would either have to undo the edits I made since then - or to the best of my ability try to move the object back to the original position, which is not always that easy.
Is there a chance we could have an option to undo edits to selected object(s)?
Attachments (1)
Change History (11)
follow-up: 2 comment:1 by , 5 years ago
comment:2 by , 5 years ago
Replying to Klumbumbus:
If I remember correctly purge the object and redownload it from the server works.
Nice but limited workaround. Did that several times but gets nasty with relations, new objects and partial undo, like only change of position and not tags.
See #4608.
by , 5 years ago
Attachment: | 18133.patch added |
---|
comment:3 by , 5 years ago
Milestone: | → 20.02 |
---|---|
Owner: | changed from | to
Status: | new → assigned |
Summary: | Undo edit to selected object(s) → [Patch] Undo edit to selected object(s) |
comment:4 by , 5 years ago
Doesn't work for me.
What steps will reproduce the problem?
- Draw a new way
- Tag it with highway=residential
- Draw another way
- Add name=test to the first way
- Undo "Set highway=residential"
What is the expected result?
First way has tag name=test , second way is unchanged
What happens instead?
First way has no tags, 2nd way disappears
Even clicking Redo doesn't get me to this result.
My understanding is that you can only undo a command which contains only objects which were not changed later on.
comment:5 by , 5 years ago
Oh, just noticed that you added a "Undo this action". I think it should be "Undo this command".
So, forget above results as I tested the standard "Undo" button.
Anyway, the results are still not correct. Repeat steps 1-4 and use "Undo this action" on "Set highway=residential" gives
First way has no tags, 2nd way is unchanged.
My conclusion remains the same.
comment:7 by , 5 years ago
Milestone: | 20.02 → 20.03 |
---|
comment:8 by , 5 years ago
Milestone: | 20.03 → 20.04 |
---|
comment:9 by , 5 years ago
Milestone: | 20.04 |
---|---|
Owner: | changed from | to
Status: | assigned → new |
Summary: | [Patch] Undo edit to selected object(s) → [Patch draft] Undo edit to selected object(s) |
comment:10 by , 5 years ago
Cc: | added |
---|
skyper in ticket:4608
possibility to undo not just the last edit but any edit and raise a conflict if needed.
skyper in ticket:4608#comment:4
Undoing any edit separately would be a major enhancement. Just did get the info about deleting a node (by mistake) in the upload summary. The deletion had taken place more than 50 edits in advance. Only had two possibility to solve:
- download the node again in an extra layer, modify it and merge the layers (did not exactly know the position)
- save the data and edit the file with an text editor (that is what I did).
skyper in ticket:4608#comment:5
If 3. gets implemented some direct selection of objects in command line dialog from selection list's context menu would be nice or even an extra edit action "forget my changes".
If I remember correctly purge the object and redownload it from the server works.