Modify ↓

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#18130 closed defect (fixed)

[Patch] Deleting geotagged image doesn't jump to next image anymore

Reported by: skorbut Owned by: francois2
Priority: normal Milestone: 19.09
Component: Core image mapping Version:
Keywords: template_report regression Cc: francois2

Description (last modified by Don-vip)

What steps will reproduce the problem?

  1. Drag-and-drop a directory of geotagged images into JOSM
  2. Delete one of the images permanently using the disc-with-red-cross-button in the JOSM image viewer

What is the expected result?

The viewer should display the next image in the sequence.

What happens instead?

The viewer doesn't display any image, the control buttons are greyed out, there is a text No image. Other images can still be selected and displayed.

Please provide any additional information below. Attach a screenshot if possible.

This behaviour is quite new, it can only be a few days old. Maybe it's related to the activities in #11905 ?

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-09-12 23:23:47 +0200 (Thu, 12 Sep 2019)
Revision:15348
Build-Date:2019-09-12 21:28:35
URL:https://josm.openstreetmap.de/svn/trunk

... snip ...

Attachments (1)

patch_select_image_after_remove.patch​ (3.2 KB ) - added by francois2 5 years ago.
Select next image after remove

Download all attachments as: .zip

Change History (9)

comment:1 by Don-vip, 5 years ago

Cc: francois2 added
Description: modified (diff)
Keywords: regression added
Milestone: → 19.09

@francois2 can you please take a look?

in reply to:  description comment:2 by Don-vip, 5 years ago

Replying to skorbut:

... snip ...

Please don't do that. Java version and OS information is the most crucial piece of information of status reports.

comment:3 by francois2, 5 years ago

I'll take a look tomorrow.

comment:4 by francois2, 5 years ago

Owner: changed from team to francois2

by francois2, 5 years ago

Attachment: patch_select_image_after_remove.patch​ added

Select next image after remove

comment:5 by francois2, 5 years ago

Summary: Deleting geotagged image doesn't jump to next image anymore → [Patch] Deleting geotagged image doesn't jump to next image anymore

comment:6 by Don-vip, 5 years ago

Resolution: → fixed
Status: new → closed

In 15352/josm:

fix #18130 - Select next image after remove (patch by francois2)

comment:7 by Don-vip, 5 years ago

thanks! :)

comment:8 by skorbut, 5 years ago

Seems to work fine. Thank you for your fast reaction!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain francois2.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.