Modify

Opened 5 years ago

Last modified 12 months ago

#18065 new enhancement

Add fix for "Ways with same position" warning in Validator

Reported by: shkvorets@… Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: same position fix Cc:

Description

As a result of import in Canada there are lots of ways that generate "Ways with same position" warning in JOSM.
Usually these are inner rings of a wood polygon overlapping with identical water/wetland area, or vice-versa. There are probably hundreds of thousands of these in Quebec alone. Here's one example: https://www.openstreetmap.org/way/664902128.

https://i.imgur.com/Zv0M2OE.png

Would be easy to fix such problems by removing duplicated water area and adding water tag to inner ring of the polygon. It would make import and error correction much easier.

Attachments (1)

closed_ways_with_same_position.osm (1.7 KB ) - added by zelonewolf@… 4 years ago.
Ways with same position example test case

Download all attachments as: .zip

Change History (9)

by zelonewolf@…, 4 years ago

Ways with same position example test case

comment:1 by zelonewolf@…, 4 years ago

I've attached a simple test case that demonstrates this issue. An auto-fix should allow merging of the duplicated ways provided that there is no tag collision.

comment:2 by skyper, 4 years ago

I fear problems with a autofix outside downloaded area as relations might not be downloaded.

comment:3 by anonymous, 4 years ago

Perhaps limit the auto fix to cases where the relation is fully downloaded?

comment:4 by GerdP, 4 years ago

I would agree that this could be useful if we were not talking about data from Canvec imports. IMHO it is rather useless to remove the duplicated ways as both are very likely wrong regarding the shape. Whenever I looked at this data I wondered why it was ever imported. Typical examples: way 210659483 or way 210659214.

comment:5 by zelonewolf@…, 3 years ago

Hello - I've written a standalone utility to post-process a .OSM file to fix this exact issue. If someone is looking for a way to solve this issue, feel free to get in touch!

comment:6 by skyper, 3 years ago

Keywords: same position fix added

See also #8399 for a similar request.

comment:7 by GerdP, 3 years ago

Is this problem still present in the latest Canvec data? Wouldn't it be better to fix the tool chain that produces that data?

in reply to:  5 comment:8 by anonymous, 12 months ago

Hey Zelone I am interested! Replying to zelonewolf@…:

Hello - I've written a standalone utility to post-process a .OSM file to fix this exact issue. If someone is looking for a way to solve this issue, feel free to get in touch!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to shkvorets@….
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.