[PATCH] Arbitrary changeset tags should be able to be added via remote control

[taylor.smock]

I'm specifically interested in being able to have "import=yes" added to the changeset tags.

The workflow I want to have is:

1) Download an area with JOSM using a tasking manager
2) Download an extract of data to import into JOSM (possibly using a tasking manager, if it supports it)
3) Use conflation to take data from the import data and copy it to the OSM data layer
4) Perform checks to make certain the data is OK
5) Upload the data (should have the import=yes tag, if at all possible here)

What I've tried:

1. Making certain that there is a <changeset><tag k="import" v="yes"/></changeset> in the import data layer. Conflation doesn't copy the changeset information over to the OSM data layer.

This duplicates #9387 and #9472

[taylor.smock]

Add changeset_tags to LoadAndZoomHandler, changeset_tags can be overriden with changeset_source (and other existing tags) in the current implementation

[Don-vip]

This can be rewritten to:

                    // This logic is (largely) stolen from the AddTagsDialog.
                    Set<String> tagSet = Arrays.stream(args.get("changeset_tags").split("\\|"))
                        .map(String::trim)
                        .filter(tag -> !tag.isEmpty() && tag.contains("="))
                        .collect(Collectors.toSet());

Could you please propose a refactoring where the code is shared between LoadAndZoomHandler and AddTagsDialog, instead of being copied/pasted?

[taylor.smock]

Code deduplication (new function parseUrlTagsToKeyValues)

[taylor.smock]

Use streams for initial section (where we split a url section into key=value sections)

[taylor.smock]

Use streams for the entire operation of parsing url tags. And fix a typo (\\n -> \\|).

[Don-vip]

In 15316/josm:

fix #18038 - Add arbitrary changeset tags via remote control (patch by taylor.smock)

[Don-vip]

Thanks!

[Don-vip]

In 15319/josm:

see #18038 - checkstyle

[Klumbumbus]

@Taylor, could you please update wiki:/Help/RemoteControlCommands?

[taylor.smock]

Replying to Klumbumbus:

@Taylor, could you please update wiki:/Help/RemoteControlCommands?

OK, that wiki page has been updated.

[Klumbumbus]

Thanks.

[StefanB]

Nice!
Could you add this also to the /import, pretty please? See #11310.

[taylor.smock]

Example osm file with changeset tags

[taylor.smock]

Replying to StefanB:

Nice!
Could you add this also to the /import, pretty please? See #11310.

I'll look into this, but I would need to decide what gets priority. The osm file being imported, or the URL. I personally would default to the osm file changeset tags.

For example, if the url is ​http://127.0.0.1:8111/import?changeset_tags=comment=SomeComment|source=SomeSource|import=yes&url=https://josm.openstreetmap.de/raw-attachment/ticket/18038/test.osm, the changeset tags from the test.osm file would take precedence.

I'll look into this when I have time, but I'd like to finish some other projects first (a validator test for sharp angles and a plugin for ​RapiD).