Changes between Initial Version and Version 1 of Ticket #17936


Ignore:
Timestamp:
2019-07-16T22:54:30+02:00 (6 years ago)
Author:
SlowMo24
Comment:

typo

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #17936 – Description

    initial v1  
    1515
    1616background:
    17 The offical opening_hours.js (now index.js) from https://github.com/opening-hours/opening_hours.js has moved foreward quite a bit but no release has been made since v3.5.0 in feb. 2017. Therefore it is fair eignough for JSOM to stick with the old version. But the testing of the PH and SH grammar requires opening_hours.js to know the dates of holydays in Bavaria (that is the testdummy). This should not be required (because it is only useful when displaying the result of the evaluation) but it does because JOSM does not use a customized opening_hours.js (there is no need but it might have an advantage).
    18 Now here is the point: The outdated opening_hours.js only provides holidays for bavaria up until 2017. Therefore an error occusers when the test requests the dates for `now()` (2019).
     17The offical opening_hours.js (now index.js) from https://github.com/opening-hours/opening_hours.js has moved foreward quite a bit but no release has been made since v3.5.0 in feb. 2017. Therefore it is fair eignough for JOSM to stick with the old version.
     18But the testing of the PH and SH grammar requires opening_hours.js to know the dates of holydays in Bavaria (that is the testdummy). This should not be required (because it is only useful when displaying the result of the evaluation) but it does because JOSM does not use a customized opening_hours.js (there is no need but it might have advantages).
     19Now here is the point: The outdated opening_hours.js only provides holidays for Bavaria up until 2017. Therefore an error occusers when the test requests the dates for `now()` (2019).
    1920
    2021==== Possible solutions:
    … …  
    2627
    2728==== Disclaimer:
    28 Although I have tried to investigate this issue as good as possible, I did not understand all code. Therefore the above information may be wrong. This is also why I cannot provide a codes solution.
     29Although I have tried to investigate this issue as good as possible, I did not understand all code. Therefore the above information may be wrong. This is also why I cannot provide a coded solution, sorry.
    2930PS: while we are at it, please autoformat opening_hours.js, it is unreadable in its current state.
    3031