Opened 5 years ago
Last modified 3 years ago
#17842 new enhancement
Integration with OSM wiki data items
Reported by: | Don-vip | Owned by: | team |
---|---|---|---|
Priority: | major | Milestone: | Longterm |
Component: | Core | Version: | |
Keywords: | sotmfr2019 wiki data item wikidata | Cc: | bagage, francois.lacombe, simon04 |
Description (last modified by )
We could use osmwiki:Data_items in several ways:
- validator:
- automatic rules for wrong geometries (osmwiki:Property:P33, osmwiki:Property:P34, osmwiki:Property:P35, osmwiki:Property:P36)
- automatic rules for too small/too big buildings (#17846)
- detect obsolete, deprecated, discardable values based on their status (osmwiki:Property:P6)
- validate values on their regex (osmwiki:Property:P13)
- detect missing tags (osmwiki:Property:P22)
- detect incompatible tags (osmwiki:Property:P44)
- units: Key:width → https://wiki.openstreetmap.org/wiki/Key:width → https://www.wikidata.org/wiki/Q35059 → recommended unit of measurement (P8111), ISQ dimension (P4020)
- warn about descriptive names (e.g. library in various languages) – #19274
- presets:
- fetch and display image+caption in presets dialogs (osmwiki:Property:P28, osmwiki:Property:47)
- translations of preset name, caption, values?
- UI:
- go to data item page when right clicking a tag (properties dialog, relation editor, changeset dialog, history dialog...)
- fetch tag description and display it in a tooltip (#18541)
- plugins
- tag2link:
- osmwiki:Property:P8 could replace the internal config files --> see #18542
- tag2link:
- more?
We could also document some JOSM features on the OSM wiki data items:
- define a "JOSM image" on the same model than "OSM Carto image" (osmwiki:Property:P39)
Related: #6450 for Taginfo integration
Attachments (0)
Change History (20)
comment:1 by , 5 years ago
Description: | modified (diff) |
---|
comment:2 by , 5 years ago
Priority: | normal → major |
---|
comment:3 by , 5 years ago
Description: | modified (diff) |
---|
comment:4 by , 5 years ago
Description: | modified (diff) |
---|
comment:5 by , 5 years ago
Description: | modified (diff) |
---|
comment:6 by , 5 years ago
Description: | modified (diff) |
---|
comment:7 by , 5 years ago
Description: | modified (diff) |
---|
follow-up: 11 comment:9 by , 5 years ago
automatic rules for wrong geometries
We already tried this in Osmose-QA back in 2012, based on wikiinfo box. But it was a fail. We removed the control. It raises too many false positives. The wiki shows ideal case, not what is on the ground or acceptable way of mapping anyway.
https://github.com/osm-fr/osmose-backend/blob/master/plugins/disabled/Wiki.py
comment:10 by , 5 years ago
Some part may be done outside of JOSM, by generating code for tools already existing like JOSM and Osmose-QA.
I am think to generate mapcss and tag2link config, as Osmose-QA also use both.
comment:11 by , 5 years ago
Replying to frodrigo:
automatic rules for wrong geometries
We already tried this in Osmose-QA back in 2012, based on wikiinfo box. But it was a fail. We removed the control. It raises too many false positives. The wiki shows ideal case, not what is on the ground or acceptable way of mapping anyway.
Maybe we can reconsider the issue if everyone (josm, id, vespucci, osmose...) contributes to fixing the false positives on the wiki? We could start by enabling this test in "info" mode to evaluate the number of false positives.
comment:12 by , 5 years ago
Description: | modified (diff) |
---|
comment:13 by , 5 years ago
Cc: | added |
---|---|
Description: | modified (diff) |
comment:14 by , 5 years ago
Description: | modified (diff) |
---|
comment:15 by , 5 years ago
In the DRC over the last few months, we have identified and sometimes reverted changesets as a consequence of this enhancement. This is because some of the tags currently used "in consensus with the community" are considered deprecated at the global level, while they are still useful and actively collected and integrated into OSM by local mappers. For instance: the "is_in" related tags. Would it be possible to consider some exceptions at the national level?
comment:16 by , 5 years ago
data items do allow us to configure usage limits - see storing geographical differences in https://wiki.openstreetmap.org/wiki/Data_items#Storing_Geographical_Differences
comment:17 by , 5 years ago
Description: | modified (diff) |
---|
comment:18 by , 5 years ago
Description: | modified (diff) |
---|
comment:19 by , 5 years ago
Milestone: | → Longterm |
---|
Thanks @Don-vip for a thorough ticket description :)
I think we might need to create multiple sub-tickets for this. The best first step would be to do the same as iD editor -- use data items to get the multilingual tag documentation (text and an image). Once this is done, we could discuss how we could integrate other features as well.
See related code at https://github.com/openstreetmap/iD/blob/fceb1a86f78deaa0853d454a5fe27d08e9f54da0/modules/services/osm_wikibase.js#L122
More specifically, use the API call to wiki to get the relevant data. Note that in the future, the exact same code will be needed to get other information about the data item. https://github.com/openstreetmap/iD/blob/fceb1a86f78deaa0853d454a5fe27d08e9f54da0/modules/services/osm_wikibase.js#L183