#17833 closed enhancement (invalid)
Cleanup tourism keys
Reported by: | anonymous | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | Internal preset | Version: | latest |
Keywords: | Cc: |
Description (last modified by )
Attachments (1)
Change History (17)
comment:1 by , 6 years ago
comment:2 by , 6 years ago
Owner: | changed from | to
---|---|
Status: | new → needinfo |
What do you mean with "cleanup" and "remove". These tags are not in the internal presets.
by , 6 years ago
Attachment: | 17833_1.png added |
---|
comment:3 by , 6 years ago
You can see those two keys in the tourism dropdown list. In my opinion they shouldn't be there.
comment:4 by , 6 years ago
Owner: | changed from | to
---|---|
Status: | needinfo → new |
comment:5 by , 6 years ago
Description: | modified (diff) |
---|
comment:6 by , 6 years ago
Description: | modified (diff) |
---|
Please add your statusreport (see newticket).
comment:7 by , 6 years ago
URL:https://josm.openstreetmap.de/svn/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2019-06-18 23:40:26 +0200 (Tue, 18 Jun 2019) Build-Date:2019-06-19 01:30:55 Revision:15185 Relative:URL: ^/trunk Identification: JOSM/1.5 (15185 en_GB) Windows 10 64-Bit OS Build number: Windows 10 Pro 1809 (17763) Memory Usage: 738 MB / 1820 MB (210 MB allocated, but free) Java version: 1.8.0_211-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Screen: \Display0 1920x1200 Maximum Screen Size: 1920x1200 VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\31\583aa85f-6f9da138, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=56766, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm-latest.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe] Dataset consistency test: No problems found Plugins: + FixAddresses (34977) + OpeningHoursEditor (34977) + apache-commons (34908) + buildings_tools (34982) + continuosDownload (82) + ejml (34908) + geojson (124) + geotools (34908) + jaxb (35014) + jts (34908) + opendata (34997) + reverter (34999) + tag2link (34977) + tageditor (34977) + turnlanes-tagging (281) + utilsplugin2 (34977) + wikipedia (v1.1.1) Map paint styles: + https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1 Validator rules: + https://josm.openstreetmap.de/josmfile?page=Rules/OsmoseValidations&zip=1
comment:9 by , 6 years ago
Resolution: | → invalid |
---|---|
Status: | new → closed |
As you don't have any other presets installed there is one of these two reasons that you see it in the list.
- the tags are used somewhere in your downloaded area
- you added the tags before during your josm session
Thats the default behavior of JOSM.
I don't think we need deprecation warnings, as for apartments there is already the "value unknown maybe apartment is meant" warning and wine_cellar is not really deprecated in the wiki.
comment:10 by , 6 years ago
If I download data from the middle of the oceans (actually nothing will be downloaded) those 2 values still remain here. Of course, I restarted JOSM several times.
So for me looks like a caching bug :/
follow-up: 12 comment:11 by , 6 years ago
They are still in the drop down list as long as they are still in the list of last used tags in the add value dialog (the list when you close the drop down menu in your screenshot).
comment:12 by , 6 years ago
Okay, so the things I tried:
- restarting JOSM
- restarting the computer
- deleting Java cache
and then after downloading data from the Atlantic Ocean, JOSM still come up with tourism=apartments and tourism=wine_cellar.
Replying to Klumbumbus:
They are still in the drop down list as long as they are still in the list of last used tags in the add value dialog (the list when you close the drop down menu in your screenshot).
These tags are not in the tag's history, at least I can't see them.
follow-up: 14 comment:13 by , 6 years ago
You are right, I just deleted the properties.recent-tags
keys and they are finally gone.
I don't remember if typed myself these values. Are they get into this list if the object tags copied and pasted to another?
comment:14 by , 6 years ago
Replying to anonym:
Are they get into this list if the object tags copied and pasted to another?
No but when editing them (even if you didn't change them when editing).
comment:16 by , 6 years ago
Wait, the user added values doesn't need to appear at the bottom of the dropdown list? Because sometimes I see them there, but not in this case.
*worldwide sorry