[Patch] Add tower:type=lighting

[anonymous]

It has its own rendering in osm-carto.
See the wiki ​https://wiki.openstreetmap.org/wiki/Key:tower:type

[Klumbumbus]

related to #16412 and #10759

[skyper]

Presets/MastAndTower supports the tag

[skyper]

communications_tower icon to be place under presets/landmark/ from ​File:Communication_tower-14.svg (PD)

[skyper]

tower:construction=freestanding icon to be place under presets/landmark/ from ​​File:Tower_freestanding.svg (PD)

[skyper]

General replacement for and tower:construction=dome icon to be place under presets/landmark/ from ​​​File:Tower_dome.svg (PD)

[skyper]

tower:construction=lattice icon to be place under presets/landmark/ from ​​​File:Tower_lattice.svg (PD)

[skyper]

tower:construction=dish icon to be place under presets/landmark/ from ​​​File:Tower_dish.svg (PD)

[skyper]

tower:type=observation/watchtower icon to be place under presets/landmark/ from ​​​File:Tower_observation.svg (PD)

[skyper]

tower:type=communication icon to be place under presets/landmark/ from ​​​File:Tower_cantilever_communication.svg (PD)

[skyper]

smaller patch for preset for #17818 and #16898

[skyper]

bigger patch for preset for #17818 and #16898

[skyper]

bigger: communication tower

[skyper]

bigger: tower

[skyper]

smaller: communications tower

[skyper]

smaller: tower

[skyper]

I have attached two versions, a smaller (josm_17818_small.patch​) and a bigger one (josm_17818_bigger.patch​).

Both add the missing tower:type values lighting and minaret and additional useful tags to man_made=tower, plus add a new preset for man_made=communications_tower (#16898). To use some chunks I did some smaller adjustments to height, ele, material and access. Additionally, I added some values_sort="false" to some tags.

The differences between smaller and bigger are:

• tower:construction=* missing in smaller
• no multiselect for tower:type=communication/watchtower in man_made=communications_tower in smaller
• smaller adds only one new icon and changes one ( to ), while bigger additionally to the two adds five more (, , , and ).

The replacement of by is useful as the first does not look nice in preset menu but not needed.
I came not around to copy some code from Presets/MastAndTower and would love to even add icons for tower:type but I did not find nice icons for radar and minaret, so far.

Please, try out and tell me which one you like better.

---

smaller:

---

bigger:

[skyper]

I could even add ​technology=* and communication:*=* like ​communication:radio=* but that might go too far.

What do you think.

[Klumbumbus]

I think that I'll have a look at the whole tower/mast/communicationtower thing in the next weeks and add internal presets based on your Mast and Tower preset.

[skyper]

Ok, then I gonna separate my patch after the holidays to turn the not directly related changes into an own patch.

[skyper]

tower part small

[skyper]

tower part bigger

[skyper]

rework of some chunks; lots of missing values_* added to combos

[skyper]

Ok, josm_17818_extra.patch​​ contains rework of <chunks> and lots of missing values_*.
I did not, yet, work through the whole defaultpresets but it is a start and ready to commit.
Some parts are needed for the tower parts below, so, this needes to be committed first/together.
josm_17818_tower_small_v2.patch​​ and josm_17818_tower_bigger_v2.patch​​ contain the tower specific parts, only.

[Klumbumbus]

In 16474/josm:

see #17818 - fine tune / unify some presets (based on patch by skyper)

[Klumbumbus]

I picked out the relevant parts of josm_17818_extra.patch​​. Some remarks:

• no values_sort="false" if unneeded or for cases without clear order (e.g. voltage, surface, map_type,...), better keep consistent alphabetical order and only disable it in exceptional cases
• no chunks for simple single tags (e.g. placement, incline, height,...)
• no unneeded comments for chunks (e.g. <!-- internet -->)
• no values_i18n="false" for numbers, these are excluded anyway
• please don't mix different things in such a big patch

[skyper]

Replying to Klumbumbus:

I picked out the relevant parts of josm_17818_extra.patch​​. Some remarks:

• no chunks for simple single tags (e.g. placement, incline, height,...)

Why? If there are many values or a description which needs to be copied and changed in every place a chunk is much easier to handle.

• please don't mix different things in such a big patch

Yeah, sorry, next time I'll split, right away.

[Klumbumbus]

Replying to skyper:

Replying to Klumbumbus:

I picked out the relevant parts of josm_17818_extra.patch​​. Some remarks:

• no chunks for simple single tags (e.g. placement, incline, height,...)

Why? If there are many values or a description which needs to be copied and changed in every place a chunk is much easier to handle.

Using chunks all over the place doesn't make the code easier, it just moves the actual code away to another place.

• please don't mix different things in such a big patch

Yeah, sorry, next time I'll split, right away.

I also meant the josm_17818_extra.patch. It combines changes of values_sort, values_i18n, preset_link, chunks, intendation changes,... which makes the patch hard to understand. Including only one of these in a patch makes it a lot easier and thus will make the patch be applied much faster.

[Klumbumbus]

Btw, the tower/mast part is still on my todo list...

[Klumbumbus]

In 16706/josm:

see #10759, see #17818, see #16898 - Add Presets for man_made=mast and man_made=communications_tower, rework preset for man_made=tower, based on patch by skyper, (all icons from ​https://wiki.openstreetmap.org/, from Geozeisig, all PD and CC0 licensed)

[Klumbumbus]

some things still todo, see ticket:10759#comment:16

[Klumbumbus]

In 16707/josm:

see #17818 - typo

[Klumbumbus]

@skyper: At wiki:/Presets/MastAndTower in "Big communication tower" you use watchtower, but meant observation, right? This is even wrong on ​https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dcommunications_tower#Useful_combinations

[skyper]

Replying to Klumbumbus:

@skyper: At wiki:/Presets/MastAndTower in "Big communication tower" you use watchtower, but meant observation, right? This is even wrong on ​osmwiki:Tag:man_made=communications_tower#Useful_combinations

You are right, I changed it in the preset which will be outdated in a few weeks anyway. The OSM wiki page still need adjustment.

[Klumbumbus]

Replying to skyper:

The OSM wiki page still need adjustment.

Done.