[Patch] Notify users of viewport following activation

[MelioraCogito]

Can't seem to find the preference which enables/DISABLES view auto-scrolling when drawing ways — centering the screen view to the newly created way point.

This is a damn annoying feature and I want to disable it.

[GerdP]

The "Viewport following" mode is toggled with Ctrl+Shift+F. You can disable that keyboard shortcut in the preferences dialog.

[Klumbumbus]

Maybe we should remove that shortcut. I already read this issue several times here in the trac or in the forum. It semms it is too easy to hit it instead of Ctrl+F. If someone really wants to use the shortcut he can manually set it again.

[GerdP]

+1

[GerdP]

On the other hand I miss the ability to configure a shortcut for "Edit: Move Node" action. The attached patch implements both changes (no shortcut by default, but possibility to configure one)

[Don-vip]

Replying to Klumbumbus:

Maybe we should remove that shortcut.

If we remove it, many people will complain. Maybe we could instead make it clear and display somewhere that "Viewport following is enabled, press Ctrl+Shift+F to disable it".

[GerdP]

If we remove it, many people will complain. Maybe we could instead make it clear and display somewhere that "Viewport following is enabled, press Ctrl+Shift+F to disable it".

Yes, maybe better to try this first. The new patch shows the message when the mode is enabled and another when it is disabled.
I see only one problem: When you press the shortcut and react quickly by pressing it again the messages are shown too long. It would be better to replace the message in the moment when the keys are pressed again, but I found no simple way to implement that.

[GerdP]

In 15023/josm:

see #17654: Allow to configure shortcut for "Move Node" action

[Don-vip]

Replying to GerdP:

I see only one problem: When you press the shortcut and react quickly by pressing it again the messages are shown too long. It would be better to replace the message in the moment when the keys are pressed again

This would require an enhancement of the Notification system:

• add an optional type or id to notifications, allowing to identifying them
• add a display mode for similar/identical notifications: append or replace
• adapt NotificationManager accordingly

[Adrian]

Replying to GerdP:

On the other hand I miss the ability to configure a shortcut for "Edit: Move Node" action.

Several years ago, I discovered a workaround for this problem. Add the button for "Edit: Move Node" to the toolbar. Then you can configure a shortcut. (I use Command+Shift+M on Mac.) Presumably this would work for any other action which has a button, and does not have the possibility to configure a shortcut.

[GerdP]

Replying to Don-vip:

Replying to GerdP:

I see only one problem: When you press the shortcut and react quickly by pressing it again the messages are shown too long. It would be better to replace the message in the moment when the keys are pressed again

This would require an enhancement of the Notification system:

• add an optional type or id to notifications, allowing to identifying them
• add a display mode for similar/identical notifications: append or replace
• adapt NotificationManager accordingly

The issue came up again in the German forum. Any idea how much work that would be? I guess we can first apply my simple patch?

[Klumbumbus]

Replying to Don-vip:

Replying to Klumbumbus:

Maybe we should remove that shortcut.

If we remove it, many people will complain.

I don't think so, as long as the users can restore the shortcut in the preferences if they really need it.

Displaying a notification doesn't really solve the problem as this can easily be overlooked.

[Klumbumbus]

Ticket #18156 has been marked as a duplicate of this ticket.

[Klumbumbus]

Ticket #18239 has been marked as a duplicate of this ticket.

[Don-vip]

@GerdP: I agree with your patch

[GerdP]

I've just learned that it doesn't work well when the shortcut was removed and the mode was switched via menu.
I think in that case it makes no sense to show the popup. Or should I change the text?

[GerdP]

v3: Only show notification when viewport following mode was changed with shortcut.

[Don-vip]

This patch looks fine :) I agree with the shortcut check.

[GerdP]

In 15705/josm:

fix #17654: Notify users of viewport following activation
Show notification when viewport following mode was activated / deactivated with shortcut

[GerdP]

Well, if there is a shortcut and the mode was activated via menu the popup will also appear. No idea if this can be changed.

[simon04]

Awesome, so often I managed to press this unknown shortcut and then I was surprised by the strange behaviour! :-)

[stoecker]

In 15708/josm:

see #17654 - allow to disable notification

[skyper]

Ticket #19408 has been marked as a duplicate of this ticket.