Reject uploads that do not follow comment/source upload policy

[Don-vip]

On the same way we warn users when they try to upload without specifying a comment or a source, it might be useful to reject uploads for which the comment or source does not follow a configurable policy (for example, absence of mandatory terms or presence of forbidden terms).

[Don-vip]

In 15010/josm:

fix #17634 - Reject uploads that do not follow comment/source upload policy, using the following 4 new properties:

• upload.comment.forbidden-terms
• upload.comment.mandatory-terms
• upload.source.forbidden-terms
• upload.source.mandatory-terms

[Don-vip]

This is what the warning looks like:

[Klumbumbus]

For now these windows will never appear as the 4 new properties are all empty, right? Do you plan to add terms? What about upload.source.forbidden-terms=google, google-maps, googlemaps, google-earth, googleearth? Is it case insensitive?

[Don-vip]

Yes the idea is to offer a configurable mechanism for those who need it (organized editing, etc.). I guess we can add some terms that apply to everyone. It is not yet case insensitive but it should.

[Don-vip]

In 15015/josm:

see #17634 - use case insensitive comparison, forbid google as source

[aceman]

Yes I also suggest to add some default set of rejected words. E.g. if the full changeset description is something like "test", "update", "correction", "edit", those should be rejected. Such descriptions without any meaning are useless for OSM.

[Don-vip]

Replying to aceman:

E.g. if the full changeset description is something like "test", "update", "correction", "edit", those should be rejected. Such descriptions without any meaning are useless for OSM.

I disagree. Something like "osmose/JOSM corrections" is something very common. Think also about "2019 cadastral update on my area", etc. Only flagrant abuses like Google Maps should be rejected by default.

[aceman]

Those would be fine.

I meant when the whole comment/description of the changeset is the single word like "correction", not when the word is only a part of it.

[Don-vip]

This is already catched by the "too short" (< 10 latin characters or < 4 CJK characters) mechanism.

[Zverikk]

Why?!
Mappers often write "google" or "yandex" as a source, helping us find malicious edits.
You are removing this option, making mappers invent something like "survey".
What do you get from that?

[stoecker]

Another why: I think for a longer time now JOSM is unable to display GoogleSat at all. They don't use TMS for their Maps-API anymore (or even image formats, but rather protobuf data).

[Stereo]

DWG still occasionally, rarely, finds people using Google satellite imagery. We have our own ways of adding that imagery to JOSM for checking.

[Zverikk]

Well, it would be much easier for DWG and local communities to find such people using changeset comments, not just a hunch.

[Don-vip]

In 15040/josm:

see #17634 - remove google from default list of forbidden terms. Useful for DWG

[Don-vip]

In 15051/josm:

see #17634 - allow to define exceptions to the list of forbidden terms, through upload.comment.exception-terms property

[Don-vip]

In 17238/josm:

see #17634 - enforce upload policy again (broken after #19381 changes)