Context Navigation

Modify ↓

#17625 closed defect (fixed)

IAE: "Node is already deleted" at buildings_tools.MergeAddrPointsAction.actionPerformed

Reported by:	alanbragg01730	Owned by:	Upliner
Priority:	normal	Milestone:
Component:	Plugin buildings_tools	Version:
Keywords:	template_report	Cc:

Description (last modified by Don-vip)

What steps will reproduce the problem?

Was using "Merge address points" under the Data menu. Task completed but got Alert "An unexpected error occurred that may have come from the Buildings_tool_plugin." I tried to update plugin before reporting bug, but there was no new version.

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-03-31 21:17:00 +0200 (Sun, 31 Mar 2019)
Build-Date:2019-03-31 20:25:18
Revision:14945
Relative:URL: ^/trunk

Identification: JOSM/1.5 (14945 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 613 MB / 989 MB (204 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) Client VM
Screen: \Display0 1366x768
Maximum Screen Size: 1366x768
Dataset consistency test: No problems found

Plugins:
+ DirectUpload (34867)
+ FixAddresses (34867)
+ Mapillary (1.5.18)
+ MicrosoftStreetside (34867)
+ SimplifyArea (34867)
+ apache-commons (34506)
+ apache-http (34632)
+ buildings_tools (34904)
+ conflation (0.6.2)
+ contourmerge (v0.1.4)
+ editgpx (34867)
+ ejml (34389)
+ geojson (116)
+ geotools (34513)
+ imagery_offset_db (34867)
+ javafx-windows
+ jaxb (34678)
+ jna (34867)
+ jts (34524)
+ measurement (34867)
+ opendata (34911)
+ scripting (30794)
+ utilsplugin2 (34932)

Tagging presets:
+ %UserProfile%\Documents\driveway.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Golf_Course&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Heritage&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Historical_Objects&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Trees&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Traffic_signs&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Noname&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1
- https://github.com/gmgeo/osmic-josm-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Historic_Stones&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Bench&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/HU-HighlightHikingTrailSigns&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lit&zip=1

Last errors/warnings:
- W: Failed to load Mappaint styles from 'https://josm.openstreetmap.de/josmfile?page=Styles/Traffic_signs&zip=1'. Exception was: java.io.IOException: The requested URL https://josm.openstreetmap.de/josmfile?page=Styles/Traffic_signs&zip=1 was not found
- E: java.io.IOException: The requested URL https://josm.openstreetmap.de/josmfile?page=Styles/Traffic_signs&zip=1 was not found
- W: Initializing map style https://josm.openstreetmap.de/josmfile?page=Styles/Traffic_signs&zip=1 completed in 142 ms (1 errors, 0 warnings)
- E: unable to find dependency javafx for plugin MicrosoftStreetside
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: Handled by bug report queue: java.lang.IllegalArgumentException: {Node id=-236138 version=0 MVDT lat=42.67718063917987,lon=-70.83609656396128} is already deleted
- W: Warning - <html>JOSM could not find information about the following plugins:<ul><li>imagery_offset_db</li><li>apache-commons</li><li>conflation</li><li>geotools</li><li>opendata</li><li>jts</li><li>Mapillary</li><li>SimplifyArea</li><li>javafx-windows</li><li>DirectUpload</li><li>ejml</li><li>FixAddresses</li><li>measurement</li><li>geojson</li><li>jaxb</li><li>scripting</li><li>editgpx</li><li>utilsplugin2</li><li>buildings_tools</li><li>jna</li><li>MicrosoftStreetside</li><li>apache-http</li><li>contourmerge</li></ul>The plugins are not going to be loaded.</html>
- W: java.util.zip.ZipException: error in opening zip file
- W: PluginException: : org.openstreetmap.josm.plugins.PluginException: Invalid jar file '<josm.pref>\plugins\OpenStreetCam.jar.new'
- W: Failed to scan file 'OpenStreetCam.jar.new' for plugin information. Skipping.


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (15) of main
java.lang.IllegalArgumentException: {Node id=-236138 version=0 MVDT lat=42.67718063917987,lon=-70.83609656396128} is already deleted
	at org.openstreetmap.josm.command.DeleteCommand.executeCommand(DeleteCommand.java:191)
	at org.openstreetmap.josm.command.SequenceCommand.executeCommand(SequenceCommand.java:79)
	at org.openstreetmap.josm.data.UndoRedoHandler.addNoRedraw(UndoRedoHandler.java:301)
	at org.openstreetmap.josm.data.UndoRedoHandler.add(UndoRedoHandler.java:355)
	at org.openstreetmap.josm.plugins.buildings_tools.MergeAddrPointsAction.actionPerformed(MergeAddrPointsAction.java:147)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.AbstractButton.doClick(Unknown Source)
	at javax.swing.plaf.basic.BasicMenuItemUI.doClick(Unknown Source)
	at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

Attachments (0)

Change History (6)

comment:1 by Don-vip, 6 years ago

Component:	Core → Plugin buildings_tools
Description:	modified (diff)
Owner:	changed from team to Upliner
Summary:	Was using "Merge address points" under the Data menu. Task completed but got Alert "An unexpected error occurred that may have come from the Buildings_tool_plugin." I tried to update plugin before reporting bug, but there was no new version. → IAE: "Node is already deleted" at buildings_tools.MergeAddrPointsAction.actionPerformed

comment:2 by anonymous, 6 years ago

Component:	Plugin buildings_tools → Core
Owner:	changed from Upliner to team
Summary:	IAE: "Node is already deleted" at buildings_tools.MergeAddrPointsAction.actionPerformed → Was using "Merge address points" under the Data menu. Task completed but got Alert "An unexpected error occurred that may have come from the Buildings_tool_plugin." I tried to update plugin before reporting bug, but there was no new version.

After submitted this report I re-ran the Data-Merge address points and it completed normally.

comment:3 by Don-vip, 6 years ago

Component:	Core → Plugin buildings_tools
Owner:	changed from team to Upliner
Summary:	Was using "Merge address points" under the Data menu. Task completed but got Alert "An unexpected error occurred that may have come from the Buildings_tool_plugin." I tried to update plugin before reporting bug, but there was no new version. → IAE: "Node is already deleted" at buildings_tools.MergeAddrPointsAction.actionPerformed

comment:4 by GerdP, 6 years ago

I can reproduce the problem like this:

have a single node with addr:housenumber=1 and two closed ways with building=yes, both covering the node

Working on a patch now...

comment:5 by GerdP, 6 years ago

I found a fix for the error but I wonder if this action works as expected.
If you have a building with addr:street=x and addr:housenumber=1 and a node inside with the same tags + shop=clothes the action removes the node and adds shop=clothes to the building.
My understanding was that it would only merge nodes where all tags have the "addr:" prefix.

Last edited 6 years ago by GerdP (previous) (diff)

comment:6 by GerdP, 6 years ago

Resolution:	→ fixed
Status:	new → closed

see [o34982:34983]

Modify Ticket

Change Properties

Summary:
Type:		Priority:
Milestone:		Component:
Version:		Keywords:
Cc:	Set your email in Preferences

Action

leave as closed The owner will remain Upliner.

change resolution as The resolution will be set.

reopen The resolution will be deleted. Next status will be 'reopened'.

Add Comment

Your email or username:

E-mail address and name can be saved in the Preferences .

You may use WikiFormatting here.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.

Download in other formats: