Progress Monitor shows no progress when reverting multiple changesets

[GerdP]

What steps will reproduce the problem?

1. revert the two changesets 47770943 68012171 to a new layer

Note that 47770943 is very complex and 68012171 is a very small change. They are not related, it's just for demonstration. 68012171 is reverted first.

What is the expected result?

Progress monitor should also show progress for the 2nd cs (47770943).

What happens instead?

The monitor shows that 13426 "missing primitives" are fetched, next it shows a 100% done (no) progress for "Downloading objects history" which takes a long time to disappear. It disappears for a very short time and reappears for a while before finally a popup with 96 conflicts appears.

Please provide any additional information below. Attach a screenshot if possible.

The monitor never shows which changeset is currently reverted.

Build-Date:2019-03-27 16:29:28
Revision:14936
Is-Local-Build:true

Identification: JOSM/1.5 (14936 SVN en) Windows 10 64-Bit
OS Build number: Windows 10 Home 1803 (17134)
Memory Usage: 569 MB / 1753 MB (436 MB allocated, but free)
Java version: 1.8.0_191-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
VM arguments: [-agentlib:jdwp=transport=dt_socket,suspend=y,address=localhost:61756, -ea, -Dfile.encoding=UTF-8]
Program arguments: [--debug]

Plugins:
+ FastDraw (34949)
+ OpeningHoursEditor (34867)
+ apache-commons (34506)
+ buildings_tools (34904)
+ continuosDownload (82)
+ download_along (34869)
+ ejml (34389)
+ geotools (34513)
+ jaxb (34678)
+ jts (34524)
+ o5m (34867)
+ opendata (34911)
+ pbf (34867)
+ poly (34867)
+ reltoolbox (34867)
+ reverter (34946)
+ undelete (34919)
+ utilsplugin2 (34932)

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

[GerdP]

I am working on a patch for this. My current approch is to add the current changeset id to the title and to use separate monitors for each complex step.

[GerdP]

Found a better solution, see [o34953:34954]:

• don't create new progress monitor in RevertChangesetTask.checkAndDownloadMissing() , instead use setTicks(0) in existing one
• add changeset id to progress bar (where possible)
• add changeset id to IllegalStateException "Missing merge target" created in ChangesetReverter
• react on Cancel button in method fixNodesWithoutCoordinates()
• fix / improve several I18N strings
• fix some javadoc/sonarLint issues
• improve code in RevertChangesetCommand (no functional change)