relation panel dont shows all relations in revert sometimes

[MKnight]

What steps will reproduce the problem?

1. close relation-panel
2. revert a CS with deleted relations for example CS67295231
3. open relation panel, there are 4 relations

1. open relation panel
2. revert a CS with deleted relations for example CS67295231
3. look at relation window, there are 2 relations

[GerdP]

@Vincent: I can reproduce this but I see that the dataset always contains 5 relations, so maybe the problem is that the relation list window is not in sync with the dataset. In my case only one relation is shown when the panel was open (2nd list of steps)
Closing and opening the relation list window shows 4 relations, searching for type:relation with checkbox "all objects" enabled shows finds 5 relations.
The attached patch seems to fix this so that always 4 relations are shown. One of the relations is very incomplete, so I guess it is intended that it doesn't appear in this window: Relation 7589682 exists only because it is a member of Relation 8329249.
What do you think?

[GerdP]

In 14886/josm:

fix #17354: Relation list is not always updated

The problem was that RelationListDialog.otherDatasetChange(AbstractDatasetChangedEvent event) did nothing.
The dialog therefore misses events of type PRIMITIVE_FLAGS_CHANGED and if the flags of a relation are changed this should change the list.
When the dialog is build from scratch it looks at the relations with status complete and shows them.

[GerdP]

Problem was not related to plugin reverter.