[PATCH] ValidatorDialog: Ignore button should be disabled sometimes
If you run validator and it shows a list of errors or warnings, you can select the entry "Errors" or "Warnings". This will enable the Ignore Button. Clicking on this button has rather unpredictable effects
and therefore the button should be disabled unless a specific type of error is selected.
Load the attached sample.osm and run validator. You shoud get a list similar to ![](/raw-attachment/ticket/17345/ignorebutton.PNG)
If you left click on Warnings the ignore button is enabled. If you click it the resulting ignore list contains
3000
303
![](/raw-attachment/ticket/17345/ignorebutton-2.PNG)
If you select the two different types of warning and click Ignore you'll get
3000_*[amenity=place_of_worship][!religion]
303
Note that the first list will ignore all errors reported by MapCSSTagChecker while the second one is much more specific. Both will not ignore "all warnings" although that would be what I would expect to happen.
My conclusion: The button should be disabled unless the selection contains a specific error.
Change History
(10)
Description: |
modified (diff)
|
Component: |
Core → Core validator
|
Milestone: |
→ 19.03
|
Summary: |
ValidatorDialog: Ignore button should be disabled sometimes → [PATCH] ValidatorDialog: Ignore button should be disabled sometimes
|
Resolution: |
→ fixed
|
Status: |
new → closed
|
The attached patch disables the Ignore button when the selected node has a depth > 1. Up to now I found only one glitch:
![](/raw-attachment/ticket/17345/OH.PNG)
The
TestError
instances produced byOpeningHourTest
are a bit special as they have very individual texts:Without the patch the ignore button would be enabled and pressing it means that code
2901
is added to the ignore list, with the patchone gets this very specific entry:
2901_opening_hours - Mo 08:00-12:00, 13:00-18:00; Di 08:00-12:00, 13:00-17:00; Mi 08:00-12:00, 13:00-18:00; Do <--- (Bitte benutze die englische Abkürzung "Th" für "do".)
While
2901
is probably too generic the latter more specific pattern is probably too specific.