#17302 closed enhancement (fixed)
Long delay when validator shows "Updating ignored errors"
Reported by: | GerdP | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 19.02 |
Component: | Core | Version: | |
Keywords: | performance | Cc: | simon04 |
Description
When you run the validator with "information level" enabled (other) it is likely to get thousands of entries. These entries are sorted using TestError.compare() which is quite costly.
On my machine it requires more than 3 seconds to sort a list of ~8850 errors like this.
Attachments (1)
Change History (4)
comment:1 by , 6 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 by , 6 years ago
Please review: TestError
still implements Comparable<TestError>
although this should no longer be needed. I did not dare to remove it because we have some plugins which use the class TestError. Will have a look later.
comment:3 by , 6 years ago
Cc: | added |
---|
I found that only the plugins pt_assistent and wikipedia refer to class TestError. I was able to compile both plugins with the attached patch. Can I simply commit it or is it better to keep the legacy code?
In 14768/josm: