#17298 closed defect (fixed)
False positive: "Error in foot:conditional value: customer is not a valid restriction value"
Reported by: | AnkEric | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 19.02 |
Component: | Core validator | Version: | |
Keywords: | Conditional_restrictions | Cc: |
Description
In a castle and castle garden (f.i. Kasteel "De Haar", Netherlands, Haarzuilens) only - paying - customers have access and only during opening_hours and only by foot (not f.i. by bicycle).
I tried to resolve by:
- highway=track/path
- access=private
- foot:conditional=customer @ (09:00-17:00)
- vehicle=no
However JOSM throws a warning:
"Error in foot:conditional value: customer is not a valid restriction value"
False positive? Or incorrect tagging?
See: https://wiki.openstreetmap.org/wiki/Conditional_restrictions
<restriction-type>[:<transportation mode>][:<direction>]:conditional = <restriction-value> @ <condition>[;<restriction-value> @ <condition>]
restriction-value
This is the actual value of the restriction, e.g. yes, private, 80, 55 mph. The restriction can be absolute (yes, no, permissive and other values that apply to everybody), according to the purpose of the highway use (destination, delivery, customer, forestry, agricultural etc.) or according to an explicit permission (private, permit_holder).
WIKI example: motor_vehicle:conditional = delivery @ (Mo-Fr 06:00-11:00,17:00-19:00;Sa 03:30-19:00)
/AnkEric
Attachments (0)
Change History (9)
comment:1 by , 6 years ago
Milestone: | → 19.02 |
---|
comment:2 by , 6 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 by , 6 years ago
Type: | enhancement → defect |
---|
comment:4 by , 6 years ago
Shouldn't it be customers
instead customer
, like https://wiki.openstreetmap.org/wiki/Key:access#Access_tag_values ?
For me it seems that who edited https://wiki.openstreetmap.org/wiki/Conditional_restrictions#Restriction-value missed an s
comment:5 by , 6 years ago
No, @naoliv you are not right!
I just changed my tags:
*foot:conditional= customers @ (09:00-17:00)
And JOSM throws the same warning:
*Error in foot:conditional value: customers is not a valid restriction value (1)
Yes, @naoliv you are right!!
*https://wiki.openstreetmap.org/wiki/Tag:access%3Dcustomers
Possible Tagging Mistakes
access=customer
If you know places with this tag, verify if it could be tagged with another tag.
For JOSM I would suggest an enhancement:
*Unknown property value - Value 'customer' for key 'access:conditional' is unknown, maybe 'customers' is meant?
Also in general: JOSM validation on "Possible Tagging Mistakes" would be "nice to have".
Does anyone know where to find OSM default Rendering script?
Should answer questions like these in a few documents.
Also, WIKI on [*:conditional] is incorrect:
- access:conditional=delivery @ (07:00-11:00); customer @ (07:00-17:00)
I will update this WIKI document after Klumbumbus has expressed his opinion. And then I should also update ± 100 incorrect tags (and hoping these won't be marked as "undiscussed mechanical edits").
So @naoliv you are right!! And thanks!
/AnkEric
comment:6 by , 6 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
REOPEN, because JOSM approval on "customer" might be a new defect, since "customer" is NOT correct. Correct is: "customers".
JOSM Validation: fix #17298 - don't warn about "customer is not a valid restriction value"
- foot:conditional= customer @ (09:00-17:00)
- 'customer' is incorrect tagging, most likely.
JOSM Validation: does not - (even after fix #17298) - accept "customers as a valid restriction value"
- foot:conditional= customers @ (09:00-17:00)
- 'customers' is correct tagging, most likely.
/AnkEric
comment:7 by , 6 years ago
Yes, 'customers' is the correct value, JOSM must not have 'customer' in a list, unless to specifically flag it as an error.
In 14767/josm: