#17240 closed enhancement (fixed)
Presets: verify that wiki links are no redirect
| Reported by: | simon04 | Owned by: | Don-vip |
|---|---|---|---|
| Priority: | minor | Milestone: | 19.10 |
| Component: | Unit tests | Version: | |
| Keywords: | preset redirect http osm-wiki | Cc: | Don-vip, stoecker |
Description (last modified by )
From ticket:17173#comment:15 Don-vip:
Replying to ticket:17173#comment:14 stoecker:
It should not be default to produce useless redirects for each wiki call.
We should add an integration test to check this.
-> after r15423 Jenkins revealed:
https://josm.openstreetmap.de/jenkins/job/JOSM-Integration/3725/testReport/
Seamarks - https://github.com/OpenNauticalChart/josm/blob/master/INT-1-preset.xmlfixedTransforMap Tag-Presets - https://github.com/species/josm-preset-transformap/blob/master/transformap.xmlfixedTaiwan Only - https://github.com/OsmHackTW/josm-presets/blob/master/TaiwanOnly.xmlfixedRussian POIs - https://github.com/ruosm-presets/literan-moscow/blob/master/russian_shops.xmlfixedCAI - https://github.com/osmItalia/cai_josm_preset/blob/master/cai.xmlfixedWindrad - https://github.com/Flacus/Windrad/blob/master/windrad.xmlfixed by mofing to our wikiRestriction signs in Poland - https://github.com/przemas75/OSM-permissions-preset/blob/master/Presets_access_PL-preset.xmlfixedAddr2 - https://josm.openstreetmap.de/wiki/Presets/Addr2fixedIranian Presets - https://josm.openstreetmap.de/wiki/Presets/Iranian_PresetfixedJapanese 50 sounds order - https://josm.openstreetmap.de/wiki/Presets/JapanfixedOpenStationMap - https://josm.openstreetmap.de/wiki/Presets/OpenStationMapfixedGerman truck toll attributes - https://josm.openstreetmap.de/wiki/Presets/OpenTollMapfixedWifi Hotspots - https://josm.openstreetmap.de/wiki/Presets/WifiHotspotsfixed
github issues see comment:9
Attachments (0)
Change History (20)
comment:1 by , 6 years ago
| Component: | Core → Unit tests |
|---|
comment:2 by , 5 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:3 by , 5 years ago
| Milestone: | → 19.10 |
|---|
comment:4 by , 5 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:6 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:7 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:8 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:9 by , 5 years ago
Github issues created:
https://github.com/OpenNauticalChart/josm/issues/11
https://github.com/species/josm-preset-transformap/issues/5
https://github.com/OsmHackTW/josm-presets/issues/5
https://github.com/ruosm-presets/literan-moscow/issues/96
https://github.com/osmItalia/cai_josm_preset/issues/7
https://github.com/Flacus/Windrad/issues/1
https://github.com/przemas75/OSM-permissions-preset/issues/1
comment:10 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:11 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:12 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:13 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:14 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:15 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:16 by , 5 years ago
Russian is also fixed. One remaining needs an ignore because of permanently changing URL. The other one seems also strange. See GitHub.
comment:17 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:18 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:20 by , 5 years ago
The test currently returns:
[Found HTTP redirection for http://kolbasa.ru/where/ -> 301 -> https://kolbasa.ru/where/, Found HTTP redirection for https://samson-pharma.ru/pharmacies -> 301 -> http://samson-pharma.ru/pharmacies/]
For me https://samson-pharma.ru/pharmacies redirects to https://samson-pharma.ru/contacts/ instead.
In 15423/josm: