replace deprecated methods, adapt to changes in core

[GerdP]

• since #14654 some core methods are deprecated which are often used in the plugin
• some methods don't work because they compare hashCode() of Dataset.getSelected()
• several equals() methods are flagged by errorprone
• javadoc is poor
• dead code should be removed

[GerdP]

work in progress

[GerdP]

fixed with [o34812:34813]
Most important change: Shift+Z and Alt+Shift+Z work again.
I fixed only those java docs where I was sure what to do.

[GerdP]

Seems that Jenkins somehow did not catch this change. I get the new plugin binary when I update but in https://josm.openstreetmap.de/jenkins/ "JOSM-Plugins" still shows 34811.

[simon04]

In the meanwhile is says Plugin-Version: 34817

Did you probably forget to svn update after your first commit, see DevelopersGuide/DevelopingPlugins#Publishingthenewplugin?

[GerdP]

I don't think so. I've committed further changes yesterday afternoon but JOSM-Plugins started this morning.
Maybe it is only executed once per day?
I'm about to commit another change in the o5m plugin this afternoon. Let's see if that changes something.

[stoecker]

Cron-Job is called every 10 minutes.

[GerdP]

So it seems that something is wrong. The commit for the src and the dist happended yesterday afternoon:
​https://trac.openstreetmap.org/log/subversion/applications/editors?rev=34819
The Jenkins build JOSM-Plugins started this morning after another dist (34819)

[GerdP]

I've now committed changes to o5m plugin. I see that Nexus-JOSM-Plugins is triggered, but not JOSM-Plugins.

[Don-vip]

Nothing wrong, look at job history, it is triggered on a time schedule, every morning.

[GerdP]

OK, thanks. Now I see that you started it manually a few times.

[Don-vip]

Yes, when the build fails I usually don't wait the next day :)

[GerdP]

I think what confused me was the link described with "Build wurde durch eine SCM-Änderung ausgelöst." (~ "Build was triggered by an SCM change.") https://josm.openstreetmap.de/jenkins/job/JOSM-Plugins/lastBuild/pollingLog
I assume there is a cron job which checks once per day if there are scm changes?

[GerdP]

I think something is wrong with the findbugs report in the JOSM-Plugins build. It shows errors for an older version of the source.
It seems that it checks out-aged binaries?
Example: I think I fixed all the problems listed here:
https://josm.openstreetmap.de/jenkins/job/JOSM-Plugins/1476/findbugsResult/module.1218276750/package.-690128254/category.672572432/

[Don-vip]

It shouldn't. Does it work locally? Maybe it was analyzed on yesterday binaries, so we have a 1-day lag. Let's see tomorrow if the errors disappear.

[GerdP]

See #17026